Merge pull request #1307 from felixfontein/json-decode

Handle return values of dec.Token() to improve error messages

Author: felixfontein

stores/json/store.go

@@ -221,7 +221,17 @@ func (store Store) jsonFromTreeBranch(branch sops.TreeBranch) ([]byte, error) {
 
 func (store Store) treeBranchFromJSON(in []byte) (sops.TreeBranch, error) {
 	dec := json.NewDecoder(bytes.NewReader(in))
-	dec.Token()
+	value, err := dec.Token()
+	if err != nil {
+		return nil, err
+	}
+	if delim, ok := value.(json.Delim); ok {
+		if delim.String() != "{" {
+			return nil, fmt.Errorf("Expected JSON object start, got delimiter %s instead", value)
+		}
+	} else {
+		return nil, fmt.Errorf("Expected JSON object start, got %#v of type %T instead", value, value)
+	}
 	return store.treeBranchFromJSONDecoder(dec)
 }
 

stores/json/store_test.go

@@ -130,6 +130,21 @@ func TestDecodeNumber(t *testing.T) {
 	in := `42`
 	_, err := Store{}.treeBranchFromJSON([]byte(in))
 	assert.NotNil(t, err)
+	assert.Equal(t, "Expected JSON object start, got 42 of type float64 instead", err.Error())
+}
+
+func TestDecodeArray(t *testing.T) {
+	in := ` [42] `
+	_, err := Store{}.treeBranchFromJSON([]byte(in))
+	assert.NotNil(t, err)
+	assert.Equal(t, "Expected JSON object start, got delimiter [ instead", err.Error())
+}
+
+func TestDecodeEmpty(t *testing.T) {
+	in := ``
+	_, err := Store{}.treeBranchFromJSON([]byte(in))
+	assert.NotNil(t, err)
+	assert.Equal(t, "EOF", err.Error())
 }
 
 func TestDecodeNestedJSONObject(t *testing.T) {