#Renamed AppNotInstalledErrorCode to AppType

#YM-23299

Author: ChethanYoti

yoti-sdk/src/main/java/com/yoti/mobile/android/sdk/YotiSDK.java

@@ -11,7 +11,7 @@
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 
-import com.yoti.mobile.android.sdk.exceptions.AppNotInstalledErrorCode;
+import com.yoti.mobile.android.sdk.exceptions.AppType;
 import com.yoti.mobile.android.sdk.exceptions.YotiSDKAppNotInstalledException;
 import com.yoti.mobile.android.sdk.exceptions.YotiSDKException;
 import com.yoti.mobile.android.sdk.exceptions.YotiSDKMinVersionException;
@@ -24,9 +24,9 @@
 
 import static com.yoti.mobile.android.sdk.ButtonTheme.THEME_PARTNERSHIP;
 import static com.yoti.mobile.android.sdk.ButtonTheme.THEME_YOTI;
-import static com.yoti.mobile.android.sdk.exceptions.AppNotInstalledErrorCode.EASY_ID_APP_NOT_INSTALLED;
-import static com.yoti.mobile.android.sdk.exceptions.AppNotInstalledErrorCode.PARTNERSHIP_APP_NOT_INSTALLED;
-import static com.yoti.mobile.android.sdk.exceptions.AppNotInstalledErrorCode.YOTI_APP_NOT_INSTALLED;
+import static com.yoti.mobile.android.sdk.exceptions.AppType.EASY_ID_APP;
+import static com.yoti.mobile.android.sdk.exceptions.AppType.PARTNERSHIP_APP;
+import static com.yoti.mobile.android.sdk.exceptions.AppType.YOTI_APP;
 
 /**
  * Singleton to manage the different Scenarios defined by a third party app.
@@ -158,22 +158,22 @@ private static PackageInfo getAppPackageInfoBasedOnTheme(PackageManager packageM
                     } else if (checkAppInstalled(packageManager, YotiAppDefs.EASY_ID_APP_PACKAGE)) {
                         packageInfo = packageManager.getPackageInfo(YotiAppDefs.EASY_ID_APP_PACKAGE, 0);
                     } else {
-                        AppNotInstalledErrorCode errorCode = buttonTheme == THEME_YOTI ? YOTI_APP_NOT_INSTALLED : PARTNERSHIP_APP_NOT_INSTALLED;
-                        throw new YotiSDKAppNotInstalledException(errorCode, "Yoti app not installed");
+                        AppType appType = buttonTheme == THEME_YOTI ? YOTI_APP : PARTNERSHIP_APP;
+                        throw new YotiSDKAppNotInstalledException(appType, appType.getValue()+" app not installed");
                     }
                     break;
                 case THEME_EASYID:
                     if (checkAppInstalled(packageManager, YotiAppDefs.EASY_ID_APP_PACKAGE)
                             && checkEasyAppWithSchemeAvailable(packageManager)) {
                         packageInfo = packageManager.getPackageInfo(YotiAppDefs.EASY_ID_APP_PACKAGE, 0);
                     } else {
-                        throw new YotiSDKAppNotInstalledException(EASY_ID_APP_NOT_INSTALLED, "EasyId app not installed");
+                        throw new YotiSDKAppNotInstalledException(EASY_ID_APP, "EasyId app not installed");
                     }
                     break;
             }
         }
         catch (NameNotFoundException e) {
-            throw new YotiSDKAppNotInstalledException(YOTI_APP_NOT_INSTALLED, "Yoti app not installed");
+            throw new YotiSDKAppNotInstalledException(YOTI_APP, "Yoti app not installed");
         }
         return packageInfo;
     }

yoti-sdk/src/main/java/com/yoti/mobile/android/sdk/exceptions/AppNotInstalledErrorCode.java

@@ -0,0 +1,17 @@
+package com.yoti.mobile.android.sdk.exceptions;
+
+public enum AppType {
+    YOTI_APP("Yoti"),
+    EASY_ID_APP("EasyId"),
+    PARTNERSHIP_APP("Yoti / EasyId");
+
+    private final String appName;
+
+    AppType(final String value) {
+        this.appName = value;
+    }
+
+    public String getValue() {
+        return appName;
+    }
+}

yoti-sdk/src/main/java/com/yoti/mobile/android/sdk/exceptions/AppType.java

@@ -2,11 +2,11 @@
 
 public class YotiSDKAppNotInstalledException extends YotiSDKException {
 
-    AppNotInstalledErrorCode errorCode;
+    AppType unavailableApp;
 
-    public YotiSDKAppNotInstalledException(AppNotInstalledErrorCode errorCode, String message) {
+    public YotiSDKAppNotInstalledException(AppType unavailableApp, String message) {
         super(message);
-        this.errorCode = errorCode;
+        this.unavailableApp = unavailableApp;
     }
 }