Merge pull request #2 from getyoti/updates

[SDK-145]: Add base64_selfie_uri

Author: zarembas

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.1.3 - 2017-11-01
+
+### Added
+- `base64_selfie_uri` value
+
 ## 1.1.2 - 2017-10-18
 
 ## 1.1.1 - 2017-09-13
@@ -16,7 +21,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - `simplecov` `~> 0.15`
 - `webmock` `~> 3.0`
 
-
 ## 1.1.0 - 2017-04-11
 Updates dependencies to the latest versions and aligns extra fields naming conventions with the Yoti attributes.
 
@@ -36,7 +40,6 @@ Updates dependencies to the latest versions and aligns extra fields naming conve
 - `simplecov` `~> 0.14`
 - `webmock` `~> 2.3`
 
-
 ## 1.0.1 - 2016-11-28
 ### Added
 - Yoti proprietary license

README.md

@@ -60,23 +60,24 @@ A call to `/auth/yoti/callback` will open the Yoti authentication page, and afte
 
 ```ruby
 {
-       "provider" => "yoti",
-            "uid" => "mHvpV4...",
-           "info" => {
-        "name" => "mHvpV4Mm+yMb..."
-    },
-    "credentials" => {},
-          "extra" => {
-                "selfie" => "data:image/jpeg;base64,/9j/2wCEAAMCAg...",
-           "given_names" => "Given Name",
-           "family_name" => "Family Name",
-          "phone_number" => "07474747474",
-         "email_address" => "[email protected]",
-         "date_of_birth" => nil,
-        "postal_address" => nil,
-                "gender" => 'MALE',
-           "nationality" => nil
-    }
+  "provider" => "yoti",
+  "uid" => "mHvpV4...",
+  "info" => {
+              "name" => "mHvpV4Mm+yMb...",
+              "base64_selfie_uri" => "data:image/jpeg;base64,/9j/2wCEAAMCAg..."
+            },
+  "credentials" => {},
+  "extra" => {
+               "selfie" => "jpeg image file",
+               "given_names" => "Given Name",
+               "family_name" => "Family Name",
+               "phone_number" => "07474747474",
+               "email_address" => "[email protected]",
+               "date_of_birth" => nil,
+               "postal_address" => nil,
+               "gender" => 'MALE',
+               "nationality" => nil
+             }
 }
 
 ```

lib/omniauth/strategies/yoti.rb

@@ -13,7 +13,10 @@ def request_phase
       end
 
       uid { yoti_user_id }
-      info { { name: yoti_user_id } }
+      info {{
+        name: yoti_user_id,
+        base64_selfie_uri: base64_selfie_uri
+      }}
 
       def extra
         @raw_info ||= {
@@ -46,11 +49,16 @@ def yoti_user_id
         yoti_activity_details.user_id
       end
 
+      def base64_selfie_uri
+        yoti_activity_details.base64_selfie_uri
+      end
+
       def configure_yoti_client!
         ::Yoti.configure do |config|
           config.client_sdk_id = options.client_options[:client_sdk_id]
           config.key_file_path = options.client_options[:key_file_path]
           config.key = options.client_options[:key]
+          config.sdk_identifier = 'OmniAuth'
         end
       end
 

lib/omniauth/yoti/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Yoti
-    VERSION = '1.1.2'.freeze
+    VERSION = '1.1.3'.freeze
   end
 end

omniauth-yoti.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.1.9'
 
   spec.add_dependency 'omniauth', '~> 1.6'
-  spec.add_dependency 'yoti', '~> 1.0'
+  spec.add_dependency 'yoti', '~> 1.1.0'
 
   spec.add_development_dependency 'bundler', '~> 1.13'
   spec.add_development_dependency 'rake', '~> 12.1'

spec/omniauth/strategies/yoti_spec.rb

@@ -46,16 +46,21 @@
   end
 
   describe '#info' do
-    it 'returns an info array' do
-      expect(subject.info).to eql(name: 'Hig2yAT79cWvseSuXcIuCLa5lNkAPy70rxetUaeHlTJGmiwc/g1MWdYWYrexWvPU')
+    it 'returns the name value' do
+      expect(subject.info[:name]).to eql('Hig2yAT79cWvseSuXcIuCLa5lNkAPy70rxetUaeHlTJGmiwc/g1MWdYWYrexWvPU')
+    end
+
+    it 'returns the base64_selfie_uri value' do
+      selfie = File.read('spec/fixtures/selfie.txt', encoding: 'utf-8')
+      expect(subject.info[:base64_selfie_uri]).to eql(selfie)
     end
   end
 
   describe '#extra' do
     context 'when using a mock request' do
       it 'has the correct selfie' do
         selfie = File.read('spec/fixtures/selfie.txt', encoding: 'utf-8')
-        expect(subject.extra[:selfie]).to eql(selfie)
+        expect('data:image/jpeg;base64,'.concat(Base64.strict_encode64(subject.extra[:selfie]))).to eql(selfie)
       end
 
       it 'has the correct phone number' do