[TASK][YD-6940] Migrate webapp module UI to Jetpack Compose #59

mircea-yoti · 2025-08-19T13:42:18Z

Purpose

The sample webapp module was using the old View system and deprecated APIs. This PR updates it to use Jetpack Compose and handle insets for edge-to-edge display.

Approach

Updated compile and target sdk version to 34
Removed deprecated storage permission requests
Migrated UI to Compose: Instead of the shake-toggled bottom sheet, show the main screen composable directly. After URL input, use navigation-compose to navigate to the web screen composable.
Enabled edge-to-edge
Migrated permission requests to use ActivityResult API
Migrated camera and file picker handling to use ActivityResult APIs

Scope of changes

webapp module UI.

Checklist

Check the web sample app works the same as before, but now with a fresh UI, drawn edge-to-edge

Tagged

@lampkicking/android-dev

Related to YD-6940

The permissions READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE are legacy permissions that grant broad, unrestricted access to the shared external storage volume. For privacy and security reasons, Google has been systematically deprecating and restricting them. After testing, it seems safe to remove them, they no longer appear to be required. Related to YD-6940

Related to YD-6940

Instead of the shake-toggled bottom sheet, show the main screen composable directly. After URL input, use navigation-compose to navigate to the web screen composable. Close-session and session-finish alert dialogs have also been migrated to Compose. Related to YD-6940

Also replace legacy AlertDialog with Composable equivalent. Related to YD-6940

Related to YD-6940

View system components were replaced with Jetpack Compose. Related to YD-6940

Related to YD-6940

Copilot

Pull Request Overview

This PR migrates the webapp module from the legacy View system to Jetpack Compose while updating deprecated APIs and enabling edge-to-edge display. The migration replaces the shake-to-configure behavior with a direct main screen UI and implements proper navigation between screens.

Key changes:

Updated compile and target SDK from 33 to 34
Migrated UI from XML layouts to Compose with MainScreen and WebScreen composables
Replaced deprecated permission handling with ActivityResult API

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
webapp/build.gradle	Updates SDK versions and dependencies to support Compose
webapp/src/main/AndroidManifest.xml	Removes deprecated storage permissions
webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/MainActivity.kt	Complete rewrite using Compose, ActivityResult APIs, and navigation
webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/MainScreen.kt	New Compose screen for URL input and session start
webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/WebScreen.kt	New Compose screen containing WebView with dialogs
webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/ui/Theme.kt	Compose theme definition
webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/AppDestinations.kt	Navigation destinations constants
webapp/src/main/res/values/strings.xml	New string resources for Compose UI
webapp/src/main/res/values/styles.xml	Simplified theme using Material Design
Multiple deleted files	Removes XML layouts, drawable, colors, and accelerometer listener

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/MainActivity.kt

webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/WebScreen.kt

damienlo · 2025-08-20T14:50:24Z

webapp/build.gradle

@@ -46,4 +48,10 @@ dependencies {
    // Multi-module projects: Add this dependency because of Android Studio Issue
    // and androix.navigation dependencies management https://issuetracker.google.com/issues/152245564
    implementation 'androidx.navigation:navigation-ui-ktx:2.2.2'
+
+    def composeBom = platform("androidx.compose:compose-bom:2025.04.00")


should we declare the versions in a dedicated file?

Done here: 74bddca 🚀

damienlo · 2025-08-20T14:52:48Z

webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/MainScreen.kt

+                value = sessionUrl,
+                onValueChange = onSessionUrlChanged,
+                label = {
+                    Text(text = stringResource(id = R.string.session_url_hint))


No color or font size/style ?

Nope, just use the default text style, should suffice given it's simply a demo app for YDS.

damienlo · 2025-08-20T14:52:58Z

webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/MainScreen.kt

+                onClick = onStartSessionClicked,
+                enabled = sessionUrl.isNotBlank()
+        ) {
+            Text(text = stringResource(id = R.string.start_session_button))


No color or font size/style ?

Please see comment above.

damienlo · 2025-08-20T14:57:08Z

webapp/build.gradle

@@ -54,4 +54,6 @@ dependencies {
    implementation 'androidx.compose.material3:material3'
    implementation 'androidx.activity:activity-compose'
    debugImplementation 'androidx.compose.ui:ui-tooling'
+
+    implementation 'androidx.navigation:navigation-compose:2.8.9'


is it ok to have the version hardcoded?

Done here: 74bddca 🚀

damienlo · 2025-08-20T15:07:35Z

webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/WebScreen.kt

+        AndroidView(
+                modifier = Modifier.fillMaxSize(),
+                factory = { context ->
+                    WebView(context).apply {
+                        WebView.setWebContentsDebuggingEnabled(BuildConfig.DEBUG)
+                        configureSettings(settings)
+                        configureWebViewClient(this, onPageCommitVisible)
+                        configureWebChromeClient(
+                                this,
+                                onFilePathCallbackReady,
+                                onShowCameraAndFilePickerChooser
+                        )
+                    }
+                },
+                update = { webView ->
+                    sessionUrl.takeIf { it.isNotBlank() }?.let { webView.loadUrl(it) }
+                }
+        )


This could be a dedicated @Composable private fun

Done here: a78069a 🚀

damienlo · 2025-08-20T15:14:57Z

webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/WebScreen.kt

+            text = { Text(stringResource(id = R.string.session_finished_dialog_text)) },
+            confirmButton = {
+                TextButton(onClick = onConfirm) {
+                    Text(stringResource(id = R.string.session_finished_dialog_confirm_button))


No color or font size/style ?

Answered above

Related to YD-6940

yotisunil

After the ID document scan, the review screen is blank.

Hence, not approved!

mircea-yoti added 9 commits August 14, 2025 12:50

Update webapp compile and target SDK version to 34

2e88364

Related to YD-6940

Implement Composables for URL input and WebView screens

80437c0

Related to YD-6940

Migrate permission requests to use ActivityResult API

f4c4f26

Also replace legacy AlertDialog with Composable equivalent. Related to YD-6940

Migrate camera and file picker handling to use ActivityResult APIs

fd9d33c

Related to YD-6940

Delete legacy UI code

c0216c1

View system components were replaced with Jetpack Compose. Related to YD-6940

Enable edge-to-edge

0f121ce

Related to YD-6940

Use rememberSaveable for sessionUrl

00b87cc

Related to YD-6940

mircea-yoti requested review from mariasenosiain and Copilot August 19, 2025 13:42

Copilot AI reviewed Aug 19, 2025

View reviewed changes

webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/MainActivity.kt Show resolved Hide resolved

webapp/src/main/java/com/yoti/mobile/android/sdk/yotidocscan/websample/WebScreen.kt Show resolved Hide resolved

damienlo reviewed Aug 20, 2025

View reviewed changes

mircea-yoti added 2 commits August 21, 2025 11:32

Declare compose dependency versions separately

74bddca

Related to YD-6940

Extract web view composable into separate fun

a78069a

Related to YD-6940

mircea-yoti requested a review from damienlo August 21, 2025 08:41

damienlo approved these changes Aug 21, 2025

View reviewed changes

mariasenosiain approved these changes Aug 27, 2025

View reviewed changes

yotisunil approved these changes Aug 28, 2025

View reviewed changes

yotisunil suggested changes Aug 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TASK][YD-6940] Migrate webapp module UI to Jetpack Compose #59

[TASK][YD-6940] Migrate webapp module UI to Jetpack Compose #59

Uh oh!

mircea-yoti commented Aug 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

damienlo Aug 20, 2025

Uh oh!

mircea-yoti Aug 21, 2025

Uh oh!

damienlo Aug 20, 2025

Uh oh!

mircea-yoti Aug 21, 2025

Uh oh!

damienlo Aug 20, 2025

Uh oh!

mircea-yoti Aug 21, 2025

Uh oh!

damienlo Aug 20, 2025

Uh oh!

mircea-yoti Aug 21, 2025

Uh oh!

damienlo Aug 20, 2025

Uh oh!

mircea-yoti Aug 21, 2025

Uh oh!

damienlo Aug 20, 2025

Uh oh!

mircea-yoti Aug 21, 2025

Uh oh!

yotisunil left a comment

Uh oh!

Uh oh!

[TASK][YD-6940] Migrate webapp module UI to Jetpack Compose #59

Are you sure you want to change the base?

[TASK][YD-6940] Migrate webapp module UI to Jetpack Compose #59

Uh oh!

Conversation

mircea-yoti commented Aug 19, 2025

Purpose

Approach

Scope of changes

Checklist

Tagged

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yotisunil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!