Skip to content

Commit 7c2210b

Browse files
committed
SDK-2661: Fix sandbox task builders, to not automatically create result object, if none of the properties are supplied
1 parent 03f6e92 commit 7c2210b

File tree

4 files changed

+23
-7
lines changed

4 files changed

+23
-7
lines changed

yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/task/SandboxDocumentTextDataExtractionTask.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,17 @@ public Builder withResultTemplate(String resultTemplate) {
124124
}
125125

126126
public SandboxDocumentTextDataExtractionTask build() {
127-
SandboxDocumentTextDataExtractionTaskResult result = new SandboxDocumentTextDataExtractionTaskResult(documentFields,
128-
documentIdPhoto,
129-
detectedCountry,
130-
detectedDocumentType,
131-
recommendation);
127+
SandboxDocumentTextDataExtractionTaskResult result;
128+
if (documentFields == null && documentIdPhoto == null && detectedCountry == null && detectedDocumentType == null && recommendation == null) {
129+
result = null;
130+
} else {
131+
result = new SandboxDocumentTextDataExtractionTaskResult(documentFields,
132+
documentIdPhoto,
133+
detectedCountry,
134+
detectedDocumentType,
135+
recommendation);
136+
}
137+
132138
return new SandboxDocumentTextDataExtractionTask(result, documentFilter, responseDelay, resultTemplate);
133139
}
134140
}

yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/task/SandboxSupplementaryDocTextDataExtractionTask.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,14 @@ public Builder withResultTemplate(String resultTemplate) {
110110
}
111111

112112
public SandboxSupplementaryDocTextDataExtractionTask build() {
113-
SandboxSupplementaryDocTextDataExtractionTaskResult result = new SandboxSupplementaryDocTextDataExtractionTaskResult(documentFields,
114-
detectedCountry, recommendation);
113+
SandboxSupplementaryDocTextDataExtractionTaskResult result;
114+
if (documentFields == null && detectedCountry == null && recommendation == null) {
115+
result = null;
116+
} else {
117+
result = new SandboxSupplementaryDocTextDataExtractionTaskResult(documentFields,
118+
detectedCountry,
119+
recommendation);
120+
}
115121
return new SandboxSupplementaryDocTextDataExtractionTask(result, documentFilter, responseDelay, resultTemplate);
116122
}
117123
}

yoti-sdk-sandbox/src/test/java/com/yoti/api/client/sandbox/docs/request/task/SandboxDocumentTextDataExtractionTaskTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static org.hamcrest.MatcherAssert.assertThat;
44
import static org.hamcrest.Matchers.hasEntry;
55
import static org.hamcrest.Matchers.is;
6+
import static org.hamcrest.Matchers.nullValue;
67

78
import java.util.Base64;
89
import java.util.HashMap;
@@ -112,6 +113,7 @@ public void builder_shouldSetResultTemplate() {
112113
.build();
113114

114115
assertThat(result.getResultTemplate(), is("someResultTemplate"));
116+
assertThat(result.getResult(), is(nullValue()));
115117
}
116118

117119
}

yoti-sdk-sandbox/src/test/java/com/yoti/api/client/sandbox/docs/request/task/SandboxSupplementaryDocTextDataExtractionTaskTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static org.hamcrest.MatcherAssert.assertThat;
44
import static org.hamcrest.Matchers.hasEntry;
55
import static org.hamcrest.Matchers.is;
6+
import static org.hamcrest.Matchers.nullValue;
67

78
import java.util.HashMap;
89
import java.util.Map;
@@ -97,6 +98,7 @@ public void builder_shouldSetResultTemplate() {
9798
.build();
9899

99100
assertThat(result.getResultTemplate(), is("someResultTemplate"));
101+
assertThat(result.getResult(), is(nullValue()));
100102
}
101103

102104
}

0 commit comments

Comments
 (0)