Skip to content

Commit b69ad19

Browse files
MrBurtyyyMrBurtyyy
committed
SDK-2675: Checks should not populate the report property, if all of the underlying properties are null
1 parent e8479d3 commit b69ad19

13 files changed

+39
-37
lines changed

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxDocumentAuthenticityCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import com.yoti.api.client.sandbox.docs.request.SandboxDocumentFilter;
64
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;
75

@@ -30,7 +28,9 @@ protected Builder self() {
3028

3129
@Override
3230
public SandboxDocumentAuthenticityCheck build() {
33-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
31+
SandboxCheckReport report = recommendation == null && breakdown == null
32+
? null
33+
: new SandboxCheckReport(recommendation, breakdown);
3434
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);
3535

3636
return new SandboxDocumentAuthenticityCheck(result, documentFilter);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxDocumentFaceMatchCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import com.yoti.api.client.sandbox.docs.request.SandboxDocumentFilter;
64
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;
75

@@ -30,7 +28,9 @@ protected Builder self() {
3028

3129
@Override
3230
public SandboxDocumentFaceMatchCheck build() {
33-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
31+
SandboxCheckReport report = recommendation == null && breakdown == null
32+
? null
33+
: new SandboxCheckReport(recommendation, breakdown);
3434
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);
3535

3636
return new SandboxDocumentFaceMatchCheck(result, documentFilter);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxDocumentTextDataCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import java.util.HashMap;
64
import java.util.Map;
75

@@ -57,7 +55,9 @@ protected Builder self() {
5755

5856
@Override
5957
public SandboxDocumentTextDataCheck build() {
60-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
58+
SandboxCheckReport report = recommendation == null && breakdown == null
59+
? null
60+
: new SandboxCheckReport(recommendation, breakdown);
6161
SandboxDocumentTextDataCheckResult result = new SandboxDocumentTextDataCheckResult(report, reportTemplate, documentFields);
6262

6363
return new SandboxDocumentTextDataCheck(result, documentFilter);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxFaceComparisonCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;
64

75
public class SandboxFaceComparisonCheck extends SandboxCheck {
@@ -28,7 +26,9 @@ protected Builder self() {
2826

2927
@Override
3028
public SandboxFaceComparisonCheck build() {
31-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
29+
SandboxCheckReport report = recommendation == null && breakdown == null
30+
? null
31+
: new SandboxCheckReport(recommendation, breakdown);
3232
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);
3333

3434
return new SandboxFaceComparisonCheck(result);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxIdDocumentComparisonCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import com.yoti.api.client.sandbox.docs.request.SandboxDocumentFilter;
64
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;
75

@@ -41,7 +39,9 @@ protected Builder self() {
4139

4240
@Override
4341
public SandboxIdDocumentComparisonCheck build() {
44-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
42+
SandboxCheckReport report = recommendation == null && breakdown == null
43+
? null
44+
: new SandboxCheckReport(recommendation, breakdown);
4545
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);
4646

4747
return new SandboxIdDocumentComparisonCheck(result, secondaryDocumentFilter);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxStaticLivenessCheckBuilder.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.validation.Validation.notNull;
4-
53
import com.yoti.api.client.docs.DocScanConstants;
64
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;
75

@@ -23,7 +21,9 @@ protected SandboxStaticLivenessCheckBuilder self() {
2321

2422
@Override
2523
public SandboxLivenessCheck build() {
26-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
24+
SandboxCheckReport report = recommendation == null && breakdown == null
25+
? null
26+
: new SandboxCheckReport(recommendation, breakdown);
2727
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);
2828

2929
return new SandboxLivenessCheck(result, DocScanConstants.STATIC, responseDelay);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxSupplementaryDocumentTextDataCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import java.util.HashMap;
64
import java.util.Map;
75

@@ -54,7 +52,9 @@ protected Builder self() {
5452

5553
@Override
5654
public SandboxSupplementaryDocumentTextDataCheck build() {
57-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
55+
SandboxCheckReport report = recommendation == null && breakdown == null
56+
? null
57+
: new SandboxCheckReport(recommendation, breakdown);
5858
SandboxSupplementaryDocumentTextDataCheckResult result = new SandboxSupplementaryDocumentTextDataCheckResult(report, reportTemplate, documentFields);
5959

6060
return new SandboxSupplementaryDocumentTextDataCheck(result, documentFilter);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxSynecticsIdentityFraudCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;
64

75
public class SandboxSynecticsIdentityFraudCheck extends SandboxCheck {
@@ -28,7 +26,9 @@ protected Builder self() {
2826

2927
@Override
3028
public SandboxSynecticsIdentityFraudCheck build() {
31-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
29+
SandboxCheckReport report = recommendation == null && breakdown == null
30+
? null
31+
: new SandboxCheckReport(recommendation, breakdown);
3232
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);
3333

3434
return new SandboxSynecticsIdentityFraudCheck(result);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxThirdPartyIdentityCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;
64

75
public class SandboxThirdPartyIdentityCheck extends SandboxCheck {
@@ -29,7 +27,9 @@ protected Builder self() {
2927

3028
@Override
3129
public SandboxThirdPartyIdentityCheck build() {
32-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
30+
SandboxCheckReport report = recommendation == null && breakdown == null
31+
? null
32+
: new SandboxCheckReport(recommendation, breakdown);
3333
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);
3434

3535
return new SandboxThirdPartyIdentityCheck(result);

‎yoti-sdk-sandbox/src/main/java/com/yoti/api/client/sandbox/docs/request/check/SandboxThirdPartyIdentityFraudOneCheck.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.yoti.api.client.sandbox.docs.request.check;
22

3-
import static com.yoti.api.client.spi.remote.util.Validation.notNull;
4-
53
import com.yoti.api.client.sandbox.docs.request.check.report.SandboxCheckReport;
64

75
public class SandboxThirdPartyIdentityFraudOneCheck extends SandboxCheck {
@@ -28,7 +26,9 @@ protected Builder self() {
2826

2927
@Override
3028
public SandboxThirdPartyIdentityFraudOneCheck build() {
31-
SandboxCheckReport report = new SandboxCheckReport(recommendation, breakdown);
29+
SandboxCheckReport report = recommendation == null && breakdown == null
30+
? null
31+
: new SandboxCheckReport(recommendation, breakdown);
3232
SandboxCheckResult result = new SandboxCheckResult(report, reportTemplate);
3333

3434
return new SandboxThirdPartyIdentityFraudOneCheck(result);

0 commit comments

Comments
 (0)