SDK-1151: Allow multiple attributes with the same name (#138)

* SDK-1151: Support multiple attributes with the same name but different constraints

* SDK-1151: Update example to allow multiple attributes

* Change from md5 to sha-256

* Remove old examples

Co-authored-by: Rodion Liuborets <[email protected]>

Author: davidgrayston

src/Profile/BaseProfile.php

@@ -50,7 +50,7 @@ function ($carry, Attribute $attr) {
      *
      * @return \Yoti\Profile\Attribute[]
      */
-    private function getAttributesByName(string $attributeName): array
+    public function getAttributesByName(string $attributeName): array
     {
         return $this->attributesMap[$attributeName] ?? [];
     }

src/ShareUrl/Policy/DynamicPolicyBuilder.php

@@ -5,6 +5,7 @@
 namespace Yoti\ShareUrl\Policy;
 
 use Yoti\Profile\UserProfile;
+use Yoti\Util\Json;
 
 /**
  * Builder for DynamicPolicy.
@@ -49,10 +50,15 @@ class DynamicPolicyBuilder
     public function withWantedAttribute(WantedAttribute $wantedAttribute): self
     {
         $key = $wantedAttribute->getName();
+
         if ($wantedAttribute->getDerivation() !== null) {
             $key = $wantedAttribute->getDerivation();
         }
 
+        if ($wantedAttribute->getConstraints() !== null) {
+            $key .= '-' . hash('sha256', Json::encode($wantedAttribute->getConstraints()));
+        }
+
         $this->wantedAttributes[$key] = $wantedAttribute;
         return $this;
     }

tests/Profile/BaseProfileTest.php

@@ -69,7 +69,6 @@ public function setup(): void
      * @covers ::__construct
      * @covers ::getProfileAttribute
      * @covers ::setAttributesMap
-     * @covers ::getAttributesByName
      */
     public function testGetProfileAttribute()
     {
@@ -88,4 +87,24 @@ public function testGetAttributesList()
         $this->assertCount(3, $attributesList);
         $this->assertContainsOnlyInstancesOf(Attribute::class, $attributesList);
     }
+
+    /**
+     * @covers ::__construct
+     * @covers ::getAttributesByName
+     */
+    public function testGetAttributesByName()
+    {
+        $attributes = $this->baseProfile->getAttributesByName(self::SOME_ATTRIBUTE);
+        $this->assertCount(2, $attributes);
+        $this->assertSame($this->someAttribute, $attributes[0]);
+        $this->assertSame($this->someOtherAttributeWithSameName, $attributes[1]);
+
+        $invalidAttributes = $this->baseProfile->getAttributesByName(self::SOME_INVALID_ATTRIBUTE);
+        $this->assertIsArray($invalidAttributes);
+        $this->assertEmpty($invalidAttributes);
+
+        $missingAttributes = $this->baseProfile->getAttributesByName(self::SOME_MISSING_ATTRIBUTE);
+        $this->assertIsArray($missingAttributes);
+        $this->assertEmpty($missingAttributes);
+    }
 }

tests/ShareUrl/Policy/DynamicPolicyBuilderTest.php

@@ -85,7 +85,7 @@ public function testBuildWithAttributes()
     /**
      * @covers ::withWantedAttributeByName
      */
-    public function testWithWantedAttributeByName()
+    public function testWithWantedAttributeByNameWithConstraints()
     {
         $someAttributeName = 'some_attribute_name';
 
@@ -159,11 +159,47 @@ public function testWithDuplicateAttribute()
         $this->assertEquals(json_encode($expectedWantedAttributeData), json_encode($dynamicPolicy));
     }
 
+    /**
+     * @covers ::withWantedAttribute
+     * @covers ::withFamilyName
+     */
+    public function testWithDuplicateAttributeDifferentConstraints()
+    {
+        $passportConstraints = (new ConstraintsBuilder())
+            ->withSourceConstraint(
+                (new SourceConstraintBuilder())
+                    ->withPassport()
+                    ->build()
+            )
+            ->build();
+
+        $drivingLicenseConstraints = (new ConstraintsBuilder())
+            ->withSourceConstraint(
+                (new SourceConstraintBuilder())
+                    ->withDrivingLicence()
+                    ->build()
+            )
+            ->build();
+
+        $dynamicPolicy = (new DynamicPolicyBuilder())
+            ->withFamilyName()
+            ->withFamilyName($passportConstraints)
+            ->withFamilyName($drivingLicenseConstraints)
+            ->build();
+
+        $jsonData = $dynamicPolicy->jsonSerialize();
+
+        $this->assertCount(3, $jsonData->wanted);
+        foreach ($jsonData->wanted as $wantedAttribute) {
+            $this->assertEquals('family_name', $wantedAttribute->getName());
+        }
+    }
+
     /**
      * @covers ::build
      * @covers ::withWantedAttributeByName
      */
-    public function testWithAttributesByName()
+    public function testWithWantedAttributeByName()
     {
         $dynamicPolicy = (new DynamicPolicyBuilder())
             ->withWantedAttributeByName('family_name')