SDK-1019: Ensure serial number is cast to a string

Author: davidgrayston

src/Yoti/Util/Profile/AnchorConverter.php

@@ -7,6 +7,7 @@
 use phpseclib\File\X509;
 use Attrpubapi\Anchor;
 use Yoti\Entity\Anchor as YotiAnchor;
+use phpseclib\Math\BigInteger;
 
 class AnchorConverter
 {
@@ -160,7 +161,12 @@ private static function convertCertToX509($certificate)
     {
         $X509 = new X509();
         $X509Data = $X509->loadX509($certificate);
-        return json_decode(json_encode($X509Data), false);
+        $decodedX509Data = json_decode(json_encode($X509Data), false);
+        $decodedX509Data
+            ->tbsCertificate
+            ->serialNumber
+            ->value = (string) $X509Data['tbsCertificate']['serialNumber'];
+        return $decodedX509Data;
     }
 
     /**

tests/Util/Profile/AnchorConverterTest.php

@@ -102,7 +102,7 @@ private function parseFromBase64String($anchorString)
     private function assertSerialNumber($anchor, $serial_number)
     {
         $cert = $anchor->getOriginServerCerts()[0];
-        $this->assertEquals($serial_number, $cert->tbsCertificate->serialNumber->value);
+        $this->assertSame($serial_number, $cert->tbsCertificate->serialNumber->value);
     }
 
     /**