SDK-766: Return null when document images aren't converted to MultiValue

Author: davidgrayston

src/Yoti/Util/Profile/AttributeConverter.php

@@ -35,7 +35,7 @@ private static function convertValueBasedOnAttributeName($value, $attrName)
 
             case Profile::ATTR_DOCUMENT_IMAGES:
                 if (!($value instanceof MultiValue)) {
-                    return null;
+                    throw new AttributeException('Document Images could not be decoded');
                 }
                 return $value
                   ->allowInstance(Image::class)

tests/Util/Profile/AttributeConverterTest.php

@@ -179,6 +179,24 @@ public function testConvertToYotiAttributeDocumentImagesFiltered()
         $this->assertNotEmpty($multiValue[1]->getContent());
     }
 
+    /**
+     * Check that `document_images` is null when not converted to a MultiValue object.
+     *
+     * @covers ::convertToYotiAttribute
+     */
+    public function testConvertToYotiAttributeDocumentImagesInvalid()
+    {
+        // Create mock Attribute that will return MultiValue as the value.
+        $protobufAttribute = $this->getMockForProtobufAttribute(
+            'document_images',
+            'invalid value',
+            self::CONTENT_TYPE_STRING
+        );
+
+        $attr = AttributeConverter::convertToYotiAttribute($protobufAttribute);
+        $this->assertNull($attr);
+    }
+
     /**
      * Check that MultiValue object is returned for MultiValue attributes by default.
      *