Add logic and tests

Author: Rodion Liuborets

src/DocScan/Session/Create/Check/IssuingAuthoritySubCheck.php

@@ -0,0 +1,49 @@
+<?php
+
+namespace Yoti\DocScan\Session\Create\Check;
+
+use Yoti\DocScan\Session\Create\Filters\DocumentFilter;
+
+class IssuingAuthoritySubCheck
+{
+    /**
+     * @var bool|null
+     */
+    private $requested;
+
+    /**
+     * Returns the {@link DocumentFilter} that will drive which
+     * documents the sub check is performed on
+     *
+     * @var DocumentFilter|null
+     */
+    private $filter;
+
+    /**
+     * @param bool|null $requested
+     * @param DocumentFilter|null $documentFilter
+     */
+    public function __construct(?bool $requested, ?DocumentFilter $documentFilter)
+    {
+        $this->requested = $requested;
+        $this->filter = $documentFilter;
+    }
+
+    /**
+     * Returns if the issuing authority sub check has been requested
+     *
+     * @return bool|null
+     */
+    public function isRequested(): ?bool
+    {
+        return $this->requested;
+    }
+
+    /**
+     * @return DocumentFilter|null
+     */
+    public function getFilter(): ?DocumentFilter
+    {
+        return $this->filter;
+    }
+}

src/DocScan/Session/Create/Check/IssuingAuthoritySubCheckBuilder.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace Yoti\DocScan\Session\Create\Check;
+
+use Yoti\DocScan\Session\Create\Filters\DocumentFilter;
+
+class IssuingAuthoritySubCheckBuilder
+{
+    /**
+     * @var bool
+     */
+    private $requested;
+
+    /**
+     * Returns the {@link DocumentFilter} that will drive which
+     * documents the sub check is performed on
+     *
+     * @var DocumentFilter
+     */
+    private $filter;
+
+    /**
+     * @param bool $requested
+     * @return $this
+     */
+    public function withRequested(bool $requested): IssuingAuthoritySubCheckBuilder
+    {
+        $this->requested = $requested;
+
+        return $this;
+    }
+
+    /**
+     * @param DocumentFilter $filter
+     * @return $this
+     */
+    public function withDocumentFilter(DocumentFilter $filter): IssuingAuthoritySubCheckBuilder
+    {
+        $this->filter = $filter;
+
+        return $this;
+    }
+
+    /**
+     * @return IssuingAuthoritySubCheck
+     */
+    public function build(): IssuingAuthoritySubCheck
+    {
+        return new IssuingAuthoritySubCheck($this->requested, $this->filter);
+    }
+}

src/DocScan/Session/Create/Check/RequestedDocumentAuthenticityCheck.php

@@ -21,15 +21,15 @@ public function __construct(?RequestedDocumentAuthenticityCheckConfig $config =
     /**
      * @inheritDoc
      */
-    protected function getType(): string
+    public function getType(): string
     {
         return Constants::ID_DOCUMENT_AUTHENTICITY;
     }
 
     /**
      * @inheritDoc
      */
-    protected function getConfig(): ?RequestedCheckConfigInterface
+    public function getConfig(): ?RequestedCheckConfigInterface
     {
         return $this->config;
     }

src/DocScan/Session/Create/Check/RequestedDocumentAuthenticityCheckBuilder.php

@@ -4,15 +4,51 @@
 
 namespace Yoti\DocScan\Session\Create\Check;
 
+use Yoti\DocScan\Session\Create\Filters\DocumentFilter;
 use Yoti\DocScan\Session\Create\Traits\Builder\ManualCheckTrait;
 
 class RequestedDocumentAuthenticityCheckBuilder
 {
     use ManualCheckTrait;
 
+    /**
+     * @var IssuingAuthoritySubCheck|null
+     */
+    private $issuingAuthoritySubCheck;
+
+    /**
+     * @return $this
+     */
+    public function withIssuingAuthoritySubCheck(): RequestedDocumentAuthenticityCheckBuilder
+    {
+        $this->issuingAuthoritySubCheck = (new IssuingAuthoritySubCheckBuilder())
+            ->withRequested(true)
+            ->build();
+
+        return $this;
+    }
+
+    /**
+     * @param DocumentFilter $filter
+     * @return $this
+     */
+    public function withIssuingAuthoritySubCheckAndDocumentFilter(
+        DocumentFilter $filter
+    ): RequestedDocumentAuthenticityCheckBuilder {
+        $this->issuingAuthoritySubCheck = (new IssuingAuthoritySubCheckBuilder())
+            ->withRequested(true)
+            ->withDocumentFilter($filter)
+            ->build();
+
+        return $this;
+    }
+
+    /**
+     * @return RequestedDocumentAuthenticityCheck
+     */
     public function build(): RequestedDocumentAuthenticityCheck
     {
-        $config = new RequestedDocumentAuthenticityCheckConfig($this->manualCheck);
+        $config = new RequestedDocumentAuthenticityCheckConfig($this->manualCheck, $this->issuingAuthoritySubCheck);
         return new RequestedDocumentAuthenticityCheck($config);
     }
 }

src/DocScan/Session/Create/Check/RequestedDocumentAuthenticityCheckConfig.php

@@ -13,9 +13,19 @@ class RequestedDocumentAuthenticityCheckConfig implements RequestedCheckConfigIn
      */
     private $manualCheck;
 
-    public function __construct(?string $manualCheck)
+    /**
+     * @var IssuingAuthoritySubCheck|null
+     */
+    private $issuingAuthoritySubCheck;
+
+    /**
+     * @param string|null $manualCheck
+     * @param IssuingAuthoritySubCheck|null $issuingAuthoritySubCheck
+     */
+    public function __construct(?string $manualCheck, ?IssuingAuthoritySubCheck $issuingAuthoritySubCheck = null)
     {
         $this->manualCheck = $manualCheck;
+        $this->issuingAuthoritySubCheck = $issuingAuthoritySubCheck;
     }
 
     /**
@@ -25,6 +35,7 @@ public function jsonSerialize(): \stdClass
     {
         return (object) Json::withoutNullValues([
             'manual_check' => $this->getManualCheck(),
+            'issuing_authority_sub_check' => $this->getIssuingAuthoritySubCheck(),
         ]);
     }
 
@@ -35,4 +46,12 @@ public function getManualCheck(): ?string
     {
         return $this->manualCheck;
     }
+
+    /**
+     * @return IssuingAuthoritySubCheck|null
+     */
+    public function getIssuingAuthoritySubCheck(): ?IssuingAuthoritySubCheck
+    {
+        return $this->issuingAuthoritySubCheck;
+    }
 }

tests/DocScan/Session/Create/Check/IssuingAuthoritySubCheckTest.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Yoti\Test\DocScan\Session\Create\Check;
+
+use Yoti\DocScan\Session\Create\Check\IssuingAuthoritySubCheckBuilder;
+use Yoti\DocScan\Session\Create\Filters\DocumentFilter;
+use Yoti\Test\TestCase;
+
+/**
+ * @coversDefaultClass \Yoti\DocScan\Session\Create\Check\IssuingAuthoritySubCheck
+ */
+class IssuingAuthoritySubCheckTest extends TestCase
+{
+    /**
+     * @test
+     * @covers ::__construct
+     * @covers ::isRequested
+     * @covers \Yoti\DocScan\Session\Create\Check\IssuingAuthoritySubCheckBuilder::withDocumentFilter
+     * @covers \Yoti\DocScan\Session\Create\Check\IssuingAuthoritySubCheckBuilder::withRequested
+     * @covers \Yoti\DocScan\Session\Create\Check\IssuingAuthoritySubCheckBuilder::build
+     */
+    public function withRequestedAndDocumentFilterShouldSetTheValueCorrectly()
+    {
+        $documentFilterMock = $this->getMockForAbstractClass(DocumentFilter::class, ['type' => 'some']);
+
+        $result = (new IssuingAuthoritySubCheckBuilder())
+            ->withRequested(true)
+            ->withDocumentFilter($documentFilterMock)
+            ->build();
+
+        $this->assertTrue($result->isRequested());
+        $this->assertInstanceOf(DocumentFilter::class, $result->getFilter());
+    }
+}

tests/DocScan/Session/Create/Check/RequestedDocumentAuthenticityCheckBuilderTest.php

@@ -4,6 +4,8 @@
 
 use Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheck;
 use Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheckBuilder;
+use Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheckConfig;
+use Yoti\DocScan\Session\Create\Filters\DocumentFilter;
 use Yoti\Test\TestCase;
 
 /**
@@ -40,7 +42,7 @@ public function shouldJsonEncodeCorrectly()
             ->build();
 
         $expected = [
-            'config' => (object) [],
+            'config' => (object)[],
             'type' => 'ID_DOCUMENT_AUTHENTICITY',
         ];
 
@@ -57,7 +59,7 @@ public function shouldCreateCorrectString()
             ->build();
 
         $expected = [
-            'config' => (object) [],
+            'config' => (object)[],
             'type' => 'ID_DOCUMENT_AUTHENTICITY',
         ];
 
@@ -77,7 +79,7 @@ public function shouldJsonEncodeCorrectlyWithManualCheckAlways()
             ->build();
 
         $expected = [
-            'config' => (object) [
+            'config' => (object)[
                 'manual_check' => 'ALWAYS',
             ],
             'type' => 'ID_DOCUMENT_AUTHENTICITY',
@@ -99,7 +101,7 @@ public function shouldJsonEncodeCorrectlyWithManualCheckNever()
             ->build();
 
         $expected = [
-            'config' => (object) [
+            'config' => (object)[
                 'manual_check' => 'NEVER',
             ],
             'type' => 'ID_DOCUMENT_AUTHENTICITY',
@@ -121,12 +123,56 @@ public function shouldJsonEncodeCorrectlyWithManualCheckFallback()
             ->build();
 
         $expected = [
-            'config' => (object) [
+            'config' => (object)[
                 'manual_check' => 'FALLBACK',
             ],
             'type' => 'ID_DOCUMENT_AUTHENTICITY',
         ];
 
         $this->assertJsonStringEqualsJsonString(json_encode($expected), json_encode($result));
     }
+
+    /**
+     * @test
+     * @covers ::withIssuingAuthoritySubCheck
+     * @covers ::build
+     * @covers \Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheck::__construct
+     * @covers \Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheck::getConfig
+     * @covers \Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheckConfig::getIssuingAuthoritySubCheck
+     */
+    public function withIssuingAuthoritySubCheckShouldBuildDefaultObject()
+    {
+        $result = (new RequestedDocumentAuthenticityCheckBuilder())
+            ->withIssuingAuthoritySubCheck()
+            ->build();
+
+        /** @var RequestedDocumentAuthenticityCheckConfig $config */
+        $config = $result->getConfig();
+
+        $this->assertTrue($config->getIssuingAuthoritySubCheck()->isRequested());
+        $this->assertNull($config->getIssuingAuthoritySubCheck()->getFilter());
+    }
+
+    /**
+     * @test
+     * @covers ::withIssuingAuthoritySubCheckAndDocumentFilter
+     * @covers ::build
+     * @covers \Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheck::__construct
+     * @covers \Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheck::getConfig
+     * @covers \Yoti\DocScan\Session\Create\Check\RequestedDocumentAuthenticityCheckConfig::getIssuingAuthoritySubCheck
+     */
+    public function withIssuingAuthoritySubCheckShouldAcceptDocumentFilter()
+    {
+        $documentFilterMock = $this->getMockForAbstractClass(DocumentFilter::class, ['type']);
+
+        $result = (new RequestedDocumentAuthenticityCheckBuilder())
+            ->withIssuingAuthoritySubCheckAndDocumentFilter($documentFilterMock)
+            ->build();
+
+        /** @var RequestedDocumentAuthenticityCheckConfig $config */
+        $config = $result->getConfig();
+
+        $this->assertTrue($config->getIssuingAuthoritySubCheck()->isRequested());
+        $this->assertInstanceOf(DocumentFilter::class, $config->getIssuingAuthoritySubCheck()->getFilter());
+    }
 }