SDK-1814: Support PHP 8

Author: davidgrayston

.travis.yml

@@ -47,6 +47,17 @@ jobs:
         - travis_retry composer install --no-interaction --prefer-source --dev
       script:
         - composer test
+    - <<: *compatibility
+      php: "8.0snapshot"
+      install:
+        # Remove php-cs-fixer until compatible with PHP 8
+        - travis_retry composer remove --dev --no-interaction friendsofphp/php-cs-fixer
+        - travis_retry composer self-update
+        - travis_retry composer install --no-interaction --prefer-source --dev
+      before_script:
+        - echo 'xdebug.mode=coverage' >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini
+      script:
+        - composer test
     - <<: *test
       stage: Analyze
       name: Sonarcloud

composer.json

@@ -9,7 +9,7 @@
   "homepage": "https://yoti.com",
   "license": "MIT",
   "require": {
-    "php": "^7.1",
+    "php": "^7.1 || ^8.0",
     "ext-json": "*",
     "google/protobuf": "^3.10",
     "phpseclib/phpseclib": "^2.0",

tests/Http/RequestBuilderTest.php

@@ -296,14 +296,9 @@ public function testWithUnsupportedMethod()
     public function testWithHeaderInvalidValue()
     {
         $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('must be of the type string');
+        $this->expectExceptionMessage(sprintf('%s::withHeader()', RequestBuilder::class));
 
-        (new RequestBuilder())
-          ->withBaseUrl(self::SOME_BASE_URL)
-          ->withPemFilePath(TestData::PEM_FILE)
-          ->withHeader('Custom', ['invalid value'])
-          ->withMethod('GET')
-          ->build();
+        (new RequestBuilder())->withHeader('Custom', ['invalid value']);
     }
 
     /**

tests/Profile/ExtraData/AttributeDefinitionTest.php

@@ -41,7 +41,7 @@ public function testGetName()
     public function testInvalidName($invalidName)
     {
         $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('must be of the type string');
+        $this->expectExceptionMessage(sprintf('%s::__construct()', AttributeDefinition::class));
 
         new AttributeDefinition($invalidName);
     }

tests/Profile/ExtraData/AttributeIssuanceDetailsTest.php

@@ -80,7 +80,8 @@ public function testGetIssuingAttributes()
      */
     public function testInvalidToken($invalidToken)
     {
-        $this->expectException(\TypeError::class, 'must be of the type string');
+        $this->expectException(\TypeError::class);
+        $this->expectExceptionMessage(sprintf('%s::__construct()', AttributeIssuanceDetails::class));
 
         new AttributeIssuanceDetails($invalidToken);
     }

tests/ShareUrl/DynamicScenarioBuilderTest.php

@@ -4,6 +4,7 @@
 
 namespace Yoti\Test\ShareUrl;
 
+use Yoti\ShareUrl\DynamicScenario;
 use Yoti\ShareUrl\DynamicScenarioBuilder;
 use Yoti\ShareUrl\Extension\ExtensionBuilder;
 use Yoti\ShareUrl\Policy\DynamicPolicy;
@@ -94,7 +95,7 @@ public function testBuild()
     public function testBuildWithoutCallback()
     {
         $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('must be of the type string');
+        $this->expectExceptionMessage(sprintf('%s::__construct()', DynamicScenario::class));
 
         (new DynamicScenarioBuilder())
             ->withPolicy($this->createMock(DynamicPolicy::class))

tests/ShareUrl/Policy/DynamicPolicyBuilderTest.php

@@ -300,7 +300,7 @@ public function testWithAgeDerivedAttributesWithConstraints()
     public function testWithAgeOverIntegersOnly()
     {
         $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('must be of the type int');
+        $this->expectExceptionMessage(sprintf('%s::withAgeOver()', DynamicPolicyBuilder::class));
 
         (new DynamicPolicyBuilder())
             ->withDateOfBirth()
@@ -316,7 +316,7 @@ public function testWithAgeOverIntegersOnly()
     public function testWithAgeUnderIntegersOnly()
     {
         $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('must be of the type int');
+        $this->expectExceptionMessage(sprintf('%s::withAgeUnder()', DynamicPolicyBuilder::class));
 
         (new DynamicPolicyBuilder())
             ->withDateOfBirth()
@@ -527,7 +527,7 @@ public function testWithNoPinAuthAfterRemoval()
     public function testWithNonIntegerAuthType()
     {
         $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('must be of the type int');
+        $this->expectExceptionMessage(sprintf('%s::withWantedAuthType()', DynamicPolicyBuilder::class));
 
         (new DynamicPolicyBuilder())
             ->withWantedAuthType('99')

tests/ShareUrl/Policy/WantedAttributeBuilderTest.php

@@ -65,7 +65,7 @@ public function testEmptyName()
     public function testNonStringName()
     {
         $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('must be of the type string');
+        $this->expectExceptionMessage(sprintf('%s::withName()', WantedAttributeBuilder::class));
 
         (new WantedAttributeBuilder())
             ->withName(['some array'])

tests/Util/DateTimeTest.php

@@ -133,7 +133,7 @@ public function testEmptyTimestamp($emptyDateString, $exceptionMessage, $type)
     public function emptyTimestampProvider()
     {
         return [
-            [ null, 'must be of the type string, null given', \TypeError::class ],
+            [ null, sprintf('%s::stringToDateTime()', DateTime::class), \TypeError::class ],
             [ '', 'value cannot be empty', \InvalidArgumentException::class ],
         ];
     }