Code cleanup

Author: echarrod

examples/yoti_example_django/docker-compose.yml

@@ -8,4 +8,4 @@ services:
         YOTI_CLIENT_SDK_ID: "${YOTI_CLIENT_SDK_ID}"
         YOTI_KEY_FILE_PATH: "${YOTI_KEY_FILE_PATH}"
     ports:
-    - "5000:5000"
+      - "5000:5000"

examples/yoti_example_flask/docker-compose.yml

@@ -8,4 +8,4 @@ services:
         YOTI_CLIENT_SDK_ID: "${YOTI_CLIENT_SDK_ID}"
         YOTI_KEY_FILE_PATH: "${YOTI_KEY_FILE_PATH}"
     ports:
-    - "5000:5000"
+      - "5000:5000"

setup.py

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
 from setuptools import setup, find_packages
+
 from yoti_python_sdk import __version__
 
 long_description = 'This package contains the tools you need to quickly ' \
@@ -20,7 +21,8 @@
     install_requires=['cryptography>=2.2.1', 'protobuf>=3.1.0',
                       'requests>=2.11.1', 'future>=0.11.0', 'asn1==2.2.0', 'pyopenssl>=18.0.0'],
     extras_require={
-        'examples': ['Django>=1.8', 'Flask>=0.10', 'python-dotenv>=0.7.1', 'django-sslserver>=0.2', 'Werkzeug==0.11.15'],
+        'examples': ['Django>=1.8', 'Flask>=0.10', 'python-dotenv>=0.7.1', 'django-sslserver>=0.2',
+                     'Werkzeug==0.11.15'],
     },
     classifiers=[
         'Development Status :: 5 - Production/Stable',

yoti_python_sdk/__init__.py

@@ -1,8 +1,8 @@
 # -*- coding: utf-8 -*-
+from distutils.util import convert_path
 from os import environ
 
 from yoti_python_sdk.client import Client
-from distutils.util import convert_path
 
 DEFAULTS = {
     'YOTI_API_URL': 'https://api.yoti.com',

yoti_python_sdk/attribute.py

@@ -2,7 +2,9 @@
 
 
 class Attribute:
-    def __init__(self, name="", value="", anchors={}):
+    def __init__(self, name="", value="", anchors=None):
+        if anchors is None:
+            anchors = {}
         self.__name = name
         self.__value = value
         self.__anchors = anchors

yoti_python_sdk/client.py

@@ -17,7 +17,6 @@
 from yoti_python_sdk.protobuf.v1 import protobuf
 from .config import *
 
-
 NO_KEY_FILE_SPECIFIED_ERROR = 'Please specify the correct private key file ' \
                               'in Client(pem_file_path=...)\nor by setting ' \
                               'the "YOTI_KEY_FILE_PATH" environment variable'

yoti_python_sdk/profile.py

@@ -26,7 +26,7 @@ def __init__(self, profile_attributes):
                 if field.name == config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS:
                     self.try_convert_structured_postal_address_to_dict(field, anchors)
 
-            self.ensure_postal_address(anchors)
+            self.ensure_postal_address()
 
     @property
     def date_of_birth(self):
@@ -78,7 +78,6 @@ def get_attribute(self, attribute_name):
         else:
             return None
 
-
     def try_convert_structured_postal_address_to_dict(self, field, anchors):
         decoder = json.JSONDecoder(object_pairs_hook=collections.OrderedDict, strict=False)
         value_to_decode = field.value.decode()
@@ -88,12 +87,14 @@ def try_convert_structured_postal_address_to_dict(self, field, anchors):
             decoder.decode(value_to_decode),
             anchors)
 
-    def ensure_postal_address(self, anchors):
+    def ensure_postal_address(self):
         if config.ATTRIBUTE_POSTAL_ADDRESS not in self.attributes and config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS in self.attributes:
-            if config.KEY_FORMATTED_ADDRESS in self.attributes[config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value:
-                formatted_address = self.attributes[config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value[
+            structured_postal_address = self.attributes[config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS]
+
+            if config.KEY_FORMATTED_ADDRESS in structured_postal_address.value:
+                formatted_address = structured_postal_address.value[
                     config.KEY_FORMATTED_ADDRESS]
                 self.attributes[config.ATTRIBUTE_POSTAL_ADDRESS] = Attribute(
                     config.ATTRIBUTE_POSTAL_ADDRESS,
                     formatted_address,
-                    anchors)
+                    structured_postal_address.anchors)

yoti_python_sdk/protobuf/v1/protobuf.py

@@ -2,9 +2,9 @@
 from __future__ import unicode_literals
 
 from cryptography.fernet import base64
-from yoti_python_sdk.protobuf.v1.attribute_public_api import attribute_pb2, list_pb2
 
 import yoti_python_sdk.protobuf.v1.common_public_api.encrypted_data_pb2 as compubapi
+from yoti_python_sdk.protobuf.v1.attribute_public_api import attribute_pb2, list_pb2
 
 
 class Protobuf(object):