Skip to content

Commit 1046783

Browse files
echarrodecharrod
committed
SDK-442: Update test to have inline config variable
1 parent 2274887 commit 1046783

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

‎yoti_python_sdk/tests/test_activity_details.py‎

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
INDIA_COUNTRY_VALUE = "India"
6161
USA_COUNTRY_VALUE = "USA"
6262

63-
FORMATTED_ADDRESS_KEY = config.KEY_FORMATTED_ADDRESS
6463
FORMATTED_ADDRESS_VALUE = "15a North Street\nCARSHALTON\nSM5 2HW\nUK"
6564
INDIA_FORMATTED_ADDRESS_VALUE = 'S/O: Name\nHouse No.1111-A\n42nd Street\nTOWN/CITY NAME\nSub-DISTRICT 10\nDISTRICT 10\nPunjab\n141012\nRajgura Nagar\nIndia'
6665
USA_FORMATTED_ADDRESS_VALUE = "15a North Street\nTOWN/CITY NAME\nAL\n36201\nUSA"
@@ -138,7 +137,7 @@ def test_try_parse_structured_postal_address_uk():
138137
POSTAL_CODE_KEY: POSTAL_CODE_VALUE,
139138
COUNTRY_ISO_KEY: COUNTRY_ISO_VALUE,
140139
COUNTRY_KEY: COUNTRY_VALUE,
141-
FORMATTED_ADDRESS_KEY: FORMATTED_ADDRESS_VALUE}
140+
config.KEY_FORMATTED_ADDRESS: FORMATTED_ADDRESS_VALUE}
142141

143142
structured_postal_address_json = json.dumps(structured_postal_address)
144143

@@ -157,7 +156,7 @@ def test_try_parse_structured_postal_address_uk():
157156
assert actual_structured_postal_address_user_profile[POSTAL_CODE_KEY] == POSTAL_CODE_VALUE
158157
assert actual_structured_postal_address_user_profile[COUNTRY_ISO_KEY] == COUNTRY_ISO_VALUE
159158
assert actual_structured_postal_address_user_profile[COUNTRY_KEY] == COUNTRY_VALUE
160-
assert actual_structured_postal_address_user_profile[FORMATTED_ADDRESS_KEY] == FORMATTED_ADDRESS_VALUE
159+
assert actual_structured_postal_address_user_profile[config.KEY_FORMATTED_ADDRESS] == FORMATTED_ADDRESS_VALUE
161160

162161
actual_structured_postal_address_profile = activity_details.profile[
163162
config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value
@@ -170,7 +169,7 @@ def test_try_parse_structured_postal_address_uk():
170169
assert actual_structured_postal_address_profile[POSTAL_CODE_KEY] == POSTAL_CODE_VALUE
171170
assert actual_structured_postal_address_profile[COUNTRY_ISO_KEY] == COUNTRY_ISO_VALUE
172171
assert actual_structured_postal_address_profile[COUNTRY_KEY] == COUNTRY_VALUE
173-
assert actual_structured_postal_address_profile[FORMATTED_ADDRESS_KEY] == FORMATTED_ADDRESS_VALUE
172+
assert actual_structured_postal_address_profile[config.KEY_FORMATTED_ADDRESS] == FORMATTED_ADDRESS_VALUE
174173

175174

176175
def test_try_parse_structured_postal_address_india():
@@ -187,7 +186,7 @@ def test_try_parse_structured_postal_address_india():
187186
POST_OFFICE_KEY: INDIA_POST_OFFICE_VALUE,
188187
COUNTRY_ISO_KEY: INDIA_COUNTRY_ISO_VALUE,
189188
COUNTRY_KEY: INDIA_COUNTRY_VALUE,
190-
FORMATTED_ADDRESS_KEY: INDIA_FORMATTED_ADDRESS_VALUE}
189+
config.KEY_FORMATTED_ADDRESS: INDIA_FORMATTED_ADDRESS_VALUE}
191190

192191
structured_postal_address_json = json.dumps(structured_postal_address)
193192

@@ -211,7 +210,7 @@ def test_try_parse_structured_postal_address_india():
211210
assert actual_structured_postal_address_user_profile[POST_OFFICE_KEY] == INDIA_POST_OFFICE_VALUE
212211
assert actual_structured_postal_address_user_profile[COUNTRY_ISO_KEY] == INDIA_COUNTRY_ISO_VALUE
213212
assert actual_structured_postal_address_user_profile[COUNTRY_KEY] == INDIA_COUNTRY_VALUE
214-
assert actual_structured_postal_address_user_profile[FORMATTED_ADDRESS_KEY] == INDIA_FORMATTED_ADDRESS_VALUE
213+
assert actual_structured_postal_address_user_profile[config.KEY_FORMATTED_ADDRESS] == INDIA_FORMATTED_ADDRESS_VALUE
215214

216215
actual_structured_postal_address_profile = activity_details.profile[
217216
config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value
@@ -229,7 +228,7 @@ def test_try_parse_structured_postal_address_india():
229228
assert actual_structured_postal_address_profile[POST_OFFICE_KEY] == INDIA_POST_OFFICE_VALUE
230229
assert actual_structured_postal_address_profile[COUNTRY_ISO_KEY] == INDIA_COUNTRY_ISO_VALUE
231230
assert actual_structured_postal_address_profile[COUNTRY_KEY] == INDIA_COUNTRY_VALUE
232-
assert actual_structured_postal_address_profile[FORMATTED_ADDRESS_KEY] == INDIA_FORMATTED_ADDRESS_VALUE
231+
assert actual_structured_postal_address_profile[config.KEY_FORMATTED_ADDRESS] == INDIA_FORMATTED_ADDRESS_VALUE
233232

234233

235234
def test_try_parse_structured_postal_address_usa():
@@ -241,7 +240,7 @@ def test_try_parse_structured_postal_address_usa():
241240
POSTAL_CODE_KEY: USA_POSTAL_CODE_VALUE,
242241
COUNTRY_ISO_KEY: USA_COUNTRY_ISO_VALUE,
243242
COUNTRY_KEY: USA_COUNTRY_VALUE,
244-
FORMATTED_ADDRESS_KEY: USA_FORMATTED_ADDRESS_VALUE}
243+
config.KEY_FORMATTED_ADDRESS: USA_FORMATTED_ADDRESS_VALUE}
245244

246245
structured_postal_address_json = json.dumps(structured_postal_address)
247246

@@ -260,7 +259,7 @@ def test_try_parse_structured_postal_address_usa():
260259
assert actual_structured_postal_address_user_profile[POSTAL_CODE_KEY] == USA_POSTAL_CODE_VALUE
261260
assert actual_structured_postal_address_user_profile[COUNTRY_ISO_KEY] == USA_COUNTRY_ISO_VALUE
262261
assert actual_structured_postal_address_user_profile[COUNTRY_KEY] == USA_COUNTRY_VALUE
263-
assert actual_structured_postal_address_user_profile[FORMATTED_ADDRESS_KEY] == USA_FORMATTED_ADDRESS_VALUE
262+
assert actual_structured_postal_address_user_profile[config.KEY_FORMATTED_ADDRESS] == USA_FORMATTED_ADDRESS_VALUE
264263

265264
actual_structured_postal_address_profile = activity_details.profile[
266265
config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value
@@ -273,7 +272,7 @@ def test_try_parse_structured_postal_address_usa():
273272
assert actual_structured_postal_address_profile[POSTAL_CODE_KEY] == USA_POSTAL_CODE_VALUE
274273
assert actual_structured_postal_address_profile[COUNTRY_ISO_KEY] == USA_COUNTRY_ISO_VALUE
275274
assert actual_structured_postal_address_profile[COUNTRY_KEY] == USA_COUNTRY_VALUE
276-
assert actual_structured_postal_address_profile[FORMATTED_ADDRESS_KEY] == USA_FORMATTED_ADDRESS_VALUE
275+
assert actual_structured_postal_address_profile[config.KEY_FORMATTED_ADDRESS] == USA_FORMATTED_ADDRESS_VALUE
277276

278277

279278
def test_try_parse_structured_postal_address_nested_json():
@@ -296,7 +295,7 @@ def test_try_parse_structured_postal_address_nested_json():
296295
POSTAL_CODE_KEY: POSTAL_CODE_VALUE,
297296
COUNTRY_ISO_KEY: COUNTRY_ISO_VALUE,
298297
COUNTRY_KEY: COUNTRY_VALUE,
299-
FORMATTED_ADDRESS_KEY: formatted_address_json}
298+
config.KEY_FORMATTED_ADDRESS: formatted_address_json}
300299

301300
structured_postal_address_json = json.dumps(structured_postal_address)
302301

@@ -316,7 +315,7 @@ def test_try_parse_structured_postal_address_nested_json():
316315
assert actual_structured_postal_address_user_profile[COUNTRY_ISO_KEY] == COUNTRY_ISO_VALUE
317316
assert actual_structured_postal_address_user_profile[COUNTRY_KEY] == COUNTRY_VALUE
318317

319-
assert actual_structured_postal_address_user_profile[FORMATTED_ADDRESS_KEY] == formatted_address_json
318+
assert actual_structured_postal_address_user_profile[config.KEY_FORMATTED_ADDRESS] == formatted_address_json
320319

321320
actual_structured_postal_address_profile = activity_details.profile[
322321
config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value
@@ -330,13 +329,13 @@ def test_try_parse_structured_postal_address_nested_json():
330329
assert actual_structured_postal_address_profile[COUNTRY_ISO_KEY] == COUNTRY_ISO_VALUE
331330
assert actual_structured_postal_address_profile[COUNTRY_KEY] == COUNTRY_VALUE
332331

333-
assert actual_structured_postal_address_profile[FORMATTED_ADDRESS_KEY] == formatted_address_json
332+
assert actual_structured_postal_address_profile[config.KEY_FORMATTED_ADDRESS] == formatted_address_json
334333

335334

336335
def test_set_address_to_be_formatted_address():
337336
activity_details = ActivityDetails(successful_receipt())
338337

339-
structured_postal_address = {FORMATTED_ADDRESS_KEY: FORMATTED_ADDRESS_VALUE}
338+
structured_postal_address = {config.KEY_FORMATTED_ADDRESS: FORMATTED_ADDRESS_VALUE}
340339
structured_postal_address_json = json.dumps(structured_postal_address)
341340

342341
create_structured_postal_address_field(activity_details, structured_postal_address_json)

0 commit comments

Comments
 (0)