SDK-765: Convert multivalue list to tuple

Author: echarrod

yoti_python_sdk/attribute_parser.py

@@ -26,7 +26,7 @@ def value_based_on_content_type(value, content_type=None):
         int_value = int(string_value)
         return int_value
     elif content_type == Protobuf.CT_MULTI_VALUE:
-        return multivalue.parse(value)
+        return tuple(multivalue.parse(value))
 
     if logging.getLogger().propagate:
         logging.warning("Unknown type '{0}', attempting to parse it as a String".format(content_type))

yoti_python_sdk/tests/test_multivalue.py

@@ -5,18 +5,17 @@
 
 
 def test_multi_value_filter_image():
-    multi_value = attribute_fixture_parser.parse_multi_value()
-    multi_value.append(0)
-    multi_value.append("string_value")
+    parsed_images = attribute_fixture_parser.parse_multi_value()
+    multi_value = [parsed_images[0], parsed_images[1], 0, "string_value"]
 
     assert len(multi_value) == 4
 
-    filtered_list = multivalue.filter_values(multi_value, Image)
+    filtered_tuple = multivalue.filter_values(multi_value, Image)
 
-    assert len(filtered_list) == 2
+    assert len(filtered_tuple) == 2
 
-    image_helper.assert_is_expected_image(filtered_list[0], "jpeg", "vWgD//2Q==")
-    image_helper.assert_is_expected_image(filtered_list[1], "jpeg", "38TVEH/9k=")
+    image_helper.assert_is_expected_image(filtered_tuple[0], "jpeg", "vWgD//2Q==")
+    image_helper.assert_is_expected_image(filtered_tuple[1], "jpeg", "38TVEH/9k=")
 
 
 def test_multi_value_filter_int():
@@ -25,10 +24,10 @@ def test_multi_value_filter_int():
 
     assert len(multi_value) == 2
 
-    filtered_list = multivalue.filter_values(multi_value, int)
+    filtered_tuple = multivalue.filter_values(multi_value, int)
 
-    assert len(filtered_list) == 1
-    assert filtered_list[0] is int_value
+    assert len(filtered_tuple) == 1
+    assert filtered_tuple[0] is int_value
 
 
 def test_multi_value_filter_string():
@@ -37,18 +36,18 @@ def test_multi_value_filter_string():
 
     assert len(multi_value) == 2
 
-    filtered_list = multivalue.filter_values(multi_value, str)
+    filtered_tuple = multivalue.filter_values(multi_value, str)
 
-    assert len(filtered_list) == 1
-    assert filtered_list[0] is string_value
+    assert len(filtered_tuple) == 1
+    assert filtered_tuple[0] is string_value
 
 
 def test_multi_value_filter_is_immutable():
     original_string_value = "string_value"
     multi_value = [0, original_string_value]
 
-    filtered_list = multivalue.filter_values(multi_value, str)
+    filtered_tuple = multivalue.filter_values(multi_value, str)
 
-    filtered_list[0] == "changed_string_value"
+    filtered_tuple[0] == "changed_string_value"
 
-    assert filtered_list[0] == original_string_value
+    assert filtered_tuple[0] == original_string_value

yoti_python_sdk/tests/test_profile.py

@@ -391,20 +391,20 @@ def test_nested_multi_value():
     attribute_name = "nested_multi_value"
     inner_multi_value = attribute_fixture_parser.parse_multi_value()
 
-    outer_list = [inner_multi_value]
+    outer_tuple = (inner_multi_value,)
 
     profile = Profile(profile_attributes=None)
     profile.attributes[attribute_name] = Attribute(
         name=attribute_name,
-        value=outer_list,
+        value=outer_tuple,
         anchors=None)
 
     retrieved_multi_value = profile.get_attribute(attribute_name)
 
-    assert isinstance(retrieved_multi_value.value, list)
+    assert isinstance(retrieved_multi_value.value, tuple)
 
     for item in retrieved_multi_value.value:
-        assert isinstance(item, list)
+        assert isinstance(item, tuple)
 
     image_helper.assert_is_expected_image(retrieved_multi_value.value[0][0], "jpeg", "vWgD//2Q==")
     image_helper.assert_is_expected_image(retrieved_multi_value.value[0][1], "jpeg", "38TVEH/9k=")