SDK-1229: Add date_parser test suite for datetime_with_microsecond

Author: emmas-yoti

yoti_python_sdk/date_parser.py

@@ -19,22 +19,22 @@ def from_iso_format(string):
 
 def datetime_with_microsecond(string):
     # Python2 does not have a way of parsing date formats.
-    # TODO Deprecate this once Python2 support is dropped.
+    # Deprecate this once Python2 support is dropped.
     time_split = re.split("[^0-9]", string)
     parts = len(time_split)
     if parts <= 6:
         if logging.getLogger().propagate:
             logging.warning(ERROR_PARSING_DATE)
         return None
 
-    year = int(time_split[0]) if parts > 0 else 0
-    month = int(time_split[1]) if parts > 1 else 0
-    day = int(time_split[2]) if parts > 2 else 0
-    hour = int(time_split[3]) if parts > 3 else 0
-    minute = int(time_split[4]) if parts > 4 else 0
-    second = int(time_split[5]) if parts > 5 else 0
-    microsecond = int(float("0." + time_split[6]) * 1e6) if parts > 6 else 0
     try:
+        year = int(time_split[0])
+        month = int(time_split[1])
+        day = int(time_split[2])
+        hour = int(time_split[3])
+        minute = int(time_split[4])
+        second = int(time_split[5])
+        microsecond = int(float("0." + time_split[6]) * 1e6)
         return datetime(year, month, day, hour, minute, second, microsecond)
     except ValueError:
         if logging.getLogger().propagate:

yoti_python_sdk/tests/test_date_parser.py

@@ -0,0 +1,29 @@
+# -*- coding: utf-8 -*-
+from __future__ import unicode_literals
+
+from datetime import datetime
+from yoti_python_sdk import date_parser
+import pytest
+
+
+@pytest.mark.parametrize(
+    "string,expected",
+    [
+        ("2006-11-02T15:04:05.010Z", datetime(2006, 11, 2, 15, 4, 5, 10000)),
+        ("2006-09-02T15:04:05.010Z", datetime(2006, 9, 2, 15, 4, 5, 10000)),
+        ("2006-9-02T15:04:05.010Z", datetime(2006, 9, 2, 15, 4, 5, 10000)),
+        ("200006-11-02T15:04:05.010Z", None),
+        ("2006-13-02T15:04:05.010Z", None),
+        ("2006-09-31T15:04:05.010Z", None),
+        ("2006-11-02T15:04:05", None),
+        ("2006-11-02T15:04", None),
+        ("2006-11-02T15", None),
+        ("2006-11-02", None),
+        ("2006-11", None),
+        ("2006", None),
+        ("This is not a date", None),
+    ],
+)
+def test_datetime_with_microsecond_should_handle_missing_and_invalid(string, expected):
+    output = date_parser.datetime_with_microsecond(string)
+    assert output == expected