SDK-492: Tidy up after PR comments: remove unneccesary .items, change age_verified to not fail on non-parse, remove comment

Author: echarrod

examples/yoti_example_django/yoti_example/templates/profile.html

@@ -271,7 +271,7 @@ <h3>Yoti Profile</h3>
             <td colspan="3">
                 <table class="table">
                     <tbody>
-                    {% for source in profile.gender.sources.items %}
+                    {% for source in profile.gender.sources %}
                     <tr class="row no-gutters">
                         <td class="col-md-3">Source</td>
                         <td class="col-md-6">{{ source.value }}</td>

examples/yoti_example_flask/templates/profile.html

@@ -271,7 +271,7 @@ <h3>Yoti Profile</h3>
             <td colspan="3">
                 <table class="table">
                     <tbody>
-                    {% for source in profile.gender.sources.items %}
+                    {% for source in profile.gender.sources %}
                     <tr class="row no-gutters">
                         <td class="col-md-3">Source</td>
                         <td class="col-md-6">{{ source.value }}</td>

yoti_python_sdk/activity_details.py

@@ -59,7 +59,7 @@ def try_parse_age_verified_field(self, field):
                 self.user_profile[config.ATTRIBUTE_IS_AGE_VERIFIED] = False
                 return
 
-        raise TypeError("age_verified_field unable to be parsed")
+            print("age_verified_field value: '{0}' was unable to be parsed into a boolean value".format(is_age_verified))
 
     def try_convert_structured_postal_address_to_dict(self, field):
         decoder = json.JSONDecoder(object_pairs_hook=collections.OrderedDict, strict=False)

yoti_python_sdk/profile.py

@@ -22,13 +22,11 @@ def __init__(self, profile_attributes):
                 anchors = Anchor().parse_anchors(field.anchors)
 
                 self.profile[field.name] = Attribute(field.name, value, anchors)
-                # self.profile[field.name] = Attribute(field.name, field.value, anchors)
 
                 if field.name.startswith(config.ATTRIBUTE_AGE_OVER) or field.name.startswith(
                         config.ATTRIBUTE_AGE_UNDER):
                     self.try_parse_age_verified_field(field, anchors)
-
-                if field.name == config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS:
+                elif field.name == config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS:
                     self.try_convert_structured_postal_address_to_dict(field, anchors)
 
             self.ensure_postal_address(anchors)
@@ -100,9 +98,7 @@ def try_parse_age_verified_field(self, field, anchors):
 
     def try_convert_structured_postal_address_to_dict(self, field, anchors):
         decoder = json.JSONDecoder(object_pairs_hook=collections.OrderedDict, strict=False)
-        value_to_decode = field.value
-        if not isinstance(value_to_decode, str):
-            value_to_decode = value_to_decode.decode()
+        value_to_decode = field.value.decode()
 
         self.profile[config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS] = Attribute(
             config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS,

yoti_python_sdk/tests/test_activity_details.py

@@ -94,12 +94,12 @@ def test_try_parse_selfie_field_valid_selfie():
     assert activity_details.base64_selfie_uri is not None
 
 
-def test_try_parse_age_verified_both_missing_returns_null():
+def test_try_parse_age_verified_both_missing_not_parsed():
     activity_details = ActivityDetails(successful_receipt())
     field = None
 
-    with pytest.raises(TypeError):
-        ActivityDetails.try_parse_age_verified_field(activity_details, field)
+    ActivityDetails.try_parse_age_verified_field(activity_details, field)
+    assert not isinstance(activity_details.user_profile.get(config.ATTRIBUTE_IS_AGE_VERIFIED), bool)
 
 
 def test_try_parse_age_verified_field_age_over():
@@ -118,12 +118,12 @@ def test_try_parse_age_verified_field_age_under():
     assert activity_details.user_profile[config.ATTRIBUTE_IS_AGE_VERIFIED] is False
 
 
-def test_try_parse_age_verified_field_non_bool_value_throws_error():
+def test_try_parse_age_verified_field_non_bool_value_not_parsed():
     activity_details = ActivityDetails(successful_receipt())
     create_age_verified_field(activity_details, True, "18".encode(), 18)
 
-    with pytest.raises(TypeError):
-        ActivityDetails.try_parse_age_verified_field(activity_details, activity_details.field)
+    ActivityDetails.try_parse_age_verified_field(activity_details, activity_details.field)
+    assert not isinstance(activity_details.user_profile.get(config.ATTRIBUTE_IS_AGE_VERIFIED), bool)
 
 
 def test_try_parse_structured_postal_address_uk():

yoti_python_sdk/tests/test_profile.py

@@ -134,7 +134,7 @@ def test_try_parse_structured_postal_address_uk():
                                  COUNTRY_KEY: COUNTRY_VALUE,
                                  config.KEY_FORMATTED_ADDRESS: FORMATTED_ADDRESS_VALUE}
 
-    structured_postal_address_json = json.dumps(structured_postal_address)
+    structured_postal_address_json = json.dumps(structured_postal_address).encode()
 
     profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_json))
 
@@ -167,9 +167,9 @@ def test_try_parse_structured_postal_address_india():
                                  COUNTRY_KEY: INDIA_COUNTRY_VALUE,
                                  config.KEY_FORMATTED_ADDRESS: INDIA_FORMATTED_ADDRESS_VALUE}
 
-    structured_postal_address_json = json.dumps(structured_postal_address)
+    structured_postal_address_bytes = json.dumps(structured_postal_address).encode()
 
-    profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_json))
+    profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_bytes))
 
     actual_structured_postal_address_profile = profile.profile[
         config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value
@@ -200,9 +200,9 @@ def test_try_parse_structured_postal_address_usa():
                                  COUNTRY_KEY: USA_COUNTRY_VALUE,
                                  config.KEY_FORMATTED_ADDRESS: USA_FORMATTED_ADDRESS_VALUE}
 
-    structured_postal_address_json = json.dumps(structured_postal_address)
+    structured_postal_address_bytes = json.dumps(structured_postal_address).encode()
 
-    profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_json))
+    profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_bytes))
 
     actual_structured_postal_address_profile = profile.profile[
         config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value
@@ -239,9 +239,9 @@ def test_try_parse_structured_postal_address_nested_json():
                                  COUNTRY_KEY: COUNTRY_VALUE,
                                  config.KEY_FORMATTED_ADDRESS: formatted_address_json}
 
-    structured_postal_address_json = json.dumps(structured_postal_address)
+    structured_postal_address_bytes = json.dumps(structured_postal_address).encode()
 
-    profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_json))
+    profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_bytes))
 
     actual_structured_postal_address_profile = profile.profile[
         config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS].value
@@ -260,9 +260,9 @@ def test_try_parse_structured_postal_address_nested_json():
 
 def test_set_address_to_be_formatted_address():
     structured_postal_address = {config.KEY_FORMATTED_ADDRESS: FORMATTED_ADDRESS_VALUE}
-    structured_postal_address_json = json.dumps(structured_postal_address)
+    structured_postal_address_bytes = json.dumps(structured_postal_address).encode()
 
-    profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_json))
+    profile = Profile(create_attribute_list_with_structured_postal_address_field(structured_postal_address_bytes))
 
     assert profile.profile[config.ATTRIBUTE_POSTAL_ADDRESS].value == FORMATTED_ADDRESS_VALUE