SDK-868: Change try block to be whole attribute parsing, don't return None. Revert setup.py

Author: echarrod

setup.py

@@ -30,6 +30,9 @@
         'Operating System :: OS Independent',
         'Intended Audience :: Developers',
         'Programming Language :: Python',
+        'Programming Language :: Python :: 2',
+        'Programming Language :: Python :: 2.6',
+        'Programming Language :: Python :: 2.7',
         'Programming Language :: Python :: 3',
         'Programming Language :: Python :: 3.3',
         'Programming Language :: Python :: 3.4',

yoti_python_sdk/profile.py

@@ -20,17 +20,17 @@ def __init__(self, profile_attributes):
                         field.value,
                         field.content_type
                     )
-                except Exception as exc:
-                    error = 'Error parsing profile attribute: "{0}"'.format(field.name)
-                    logging.warning('error: {0}, exception: {1} - {2}'.format(error, type(exc).__name__, exc))
-                    value = None
 
-                anchors = Anchor().parse_anchors(field.anchors)
+                    anchors = Anchor().parse_anchors(field.anchors)
+
+                    self.attributes[field.name] = Attribute(field.name, value, anchors)
 
-                self.attributes[field.name] = Attribute(field.name, value, anchors)
+                    if field.name == config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS:
+                        self.try_convert_structured_postal_address_to_dict(field, anchors)
 
-                if field.name == config.ATTRIBUTE_STRUCTURED_POSTAL_ADDRESS:
-                    self.try_convert_structured_postal_address_to_dict(field, anchors)
+                except Exception as exc:
+                    error = 'Error parsing profile attribute: "{0}"'.format(field.name)
+                    logging.warning('error: {0}, exception: {1} - {2}'.format(error, type(exc).__name__, exc))
 
             self.ensure_postal_address()
 

yoti_python_sdk/tests/test_profile.py

@@ -124,9 +124,7 @@ def test_error_parsing_attribute_has_none_value():
 
     profile = Profile(attribute_list)
 
-    retrieved_string_attribute = profile.get_attribute(int_attribute_name)
-    assert retrieved_string_attribute.name == int_attribute_name
-    assert retrieved_string_attribute.value is None
+    assert profile.get_attribute(int_attribute_name) is None
 
 
 def test_error_parsing_attribute_does_not_affect_other_attribute():
@@ -150,7 +148,7 @@ def test_error_parsing_attribute_does_not_affect_other_attribute():
 
     profile = Profile(attribute_list)
 
-    assert len(profile.attributes) == 2
+    assert len(profile.attributes) == 1
 
     retrieved_string_attribute = profile.get_attribute(string_attribute_name)
     assert retrieved_string_attribute.name == string_attribute_name