SDK-1229: Implement extra_data tests

Author: emmas-yoti

yoti_python_sdk/issuance_details.py

@@ -10,7 +10,13 @@ def __init__(self, data_entry):
         else:
             value = data_entry.value
         self.__token = value.issuance_token.decode()
-        self.__expiry_date = value.issuing_attributes.expiry_date
+        if (
+            value.issuing_attributes.expiry_date != ""
+            and value.issuing_attributes.expiry_date is not None
+        ):
+            self.__expiry_date = value.issuing_attributes.expiry_date
+        else:
+            self.__expiry_date = None
         self.__attributes = value.issuing_attributes.definitions
 
     @property

yoti_python_sdk/tests/fixtures/testextradata.txt

@@ -0,0 +1 @@
+CmMIBhJfChFzb21lSXNzdWFuY2VUb2tlbhJKChgyMDE5LTEwLTE1VDIyOjA0OjA1LjEyM1oSEwoRY29tLnRoaXJkcGFydHkuaWQSGQoXY29tLnRoaXJkcGFydHkub3RoZXJfaWQ=

yoti_python_sdk/tests/share/test_extra_data.py

@@ -3,6 +3,7 @@
 from datetime import datetime
 from types import SimpleNamespace
 import os.path
+import pytest
 
 from yoti_python_sdk.share.extra_data import ExtraData
 from yoti_python_sdk.tests import file_helper
@@ -64,3 +65,37 @@ def test_should_parse_multiple_issuing_attributes():
     assert result.expiry_date == "2019-10-15T22:04:05.123Z"
     assert result.attributes[0].name == "com.thirdparty.id"
     assert result.attributes[1].name == "com.thirdparty.other_id"
+
+
+@pytest.mark.parametrize("no_expiry", ["", None])
+def test_should_handle_no_expiry_date(no_expiry):
+    tokenValue = "tokenValue"
+    thirdparty_attribute = create_third_party_test_data(
+        tokenValue, no_expiry, "attribute.name"
+    )
+    extra_data = ExtraData([thirdparty_attribute])
+
+    result = extra_data.attribute_issuance_details
+
+    assert result.expiry_date is None
+
+
+def test_should_handle_no_issuing_attributes():
+    tokenValue = "tokenValue"
+    thirdparty_attribute = create_third_party_test_data(tokenValue, None)
+    extra_data = ExtraData([thirdparty_attribute])
+    result = extra_data.attribute_issuance_details
+    assert result.token == "tokenValue"
+    assert len(result.attributes) == 0
+
+
+def test_should_handle_no_issuing_attribute_definitions():
+    tokenValue = "tokenValue"
+    expiry_date = datetime.now().isoformat()
+    thirdparty_attribute = create_third_party_test_data(tokenValue, expiry_date)
+
+    extra_data = ExtraData([thirdparty_attribute])
+    result = extra_data.attribute_issuance_details
+    assert result.token == tokenValue
+    assert result.expiry_date == expiry_date
+    assert len(result.attributes) == 0