SDK-1229: Add first test to test_issuance_details

Implement datetime parser for protobuf times as workaround to old Python
not being able to fully parse milli/microsecond timestamps

Author: emmas-yoti

yoti_python_sdk/issuance_details.py

@@ -1,5 +1,8 @@
 # -*- coding: utf-8 -*-
 
+from datetime import datetime
+import re
+
 
 class IssuanceDetails(object):
     def __init__(self, data_entry):
@@ -8,7 +11,20 @@ def __init__(self, data_entry):
             data_entry.issuing_attributes.expiry_date != ""
             and data_entry.issuing_attributes.expiry_date is not None
         ):
-            self.__expiry_date = data_entry.issuing_attributes.expiry_date
+            time_split = re.split("[^0-9]", data_entry.issuing_attributes.expiry_date)
+            print("!DEBUG! %s" % time_split)
+            assert len(time_split) >= 7
+            year = int(time_split[0])
+            month = int(time_split[1])
+            day = int(time_split[2])
+            hour = int(time_split[3])
+            minute = int(time_split[4])
+            second = int(time_split[5])
+            microsecond = int(float("0." + time_split[6]) * 1e6)
+            self.__expiry_date = datetime(
+                year, month, day, hour, minute, second, microsecond
+            )
+            # TODO: Refactor time parser into own method
         else:
             self.__expiry_date = None
         self.__attributes = data_entry.issuing_attributes.definitions

yoti_python_sdk/tests/fixtures/testthirdpartyattribute.txt

@@ -0,0 +1 @@
+ChFzb21lSXNzdWFuY2VUb2tlbhIvChgyMDE5LTEwLTE1VDIyOjA0OjA1LjEyM1oSEwoRY29tLnRoaXJkcGFydHkuaWQ=

yoti_python_sdk/tests/share/test_extra_data.py

@@ -54,13 +54,13 @@ def test_attribute_issuance_details_should_return_nil_when_no_data_entries():
 
 
 def test_should_return_first_matching_third_party_attribute():
-    expiry_date = datetime.now().isoformat()
+    expiry_date = datetime.now()
 
     thirdparty_attribute1 = create_third_party_test_data(
-        "tokenValue1", expiry_date, "attributeName1"
+        "tokenValue1", expiry_date.isoformat(), "attributeName1"
     )
     thirdparty_attribute2 = create_third_party_test_data(
-        "tokenValue2", expiry_date, "attributeName2"
+        "tokenValue2", expiry_date.isoformat(), "attributeName2"
     )
 
     parsed_extra_data = ExtraData(
@@ -81,7 +81,7 @@ def test_should_parse_multiple_issuing_attributes():
     result = extra_data.attribute_issuance_details
     assert result is not None
     assert result.token == "someIssuanceToken"
-    assert result.expiry_date == "2019-10-15T22:04:05.123Z"
+    assert result.expiry_date == datetime(2019, 10, 15, 22, 4, 5, 123000)
     assert result.attributes[0].name == "com.thirdparty.id"
     assert result.attributes[1].name == "com.thirdparty.other_id"
 
@@ -110,8 +110,10 @@ def test_should_handle_no_issuing_attributes():
 
 def test_should_handle_no_issuing_attribute_definitions():
     tokenValue = "tokenValue"
-    expiry_date = datetime.now().isoformat()
-    thirdparty_attribute = create_third_party_test_data(tokenValue, expiry_date)
+    expiry_date = datetime.now()
+    thirdparty_attribute = create_third_party_test_data(
+        tokenValue, expiry_date.isoformat()
+    )
     extra_data = ExtraData(create_extra_data([thirdparty_attribute]))
 
     result = extra_data.attribute_issuance_details

yoti_python_sdk/tests/test_issuance_details.py

@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+
+import os.path
+from yoti_python_sdk.tests import file_helper
+from yoti_python_sdk.issuance_details import IssuanceDetails
+from yoti_python_sdk.protobuf.share_public_api import ThirdPartyAttribute_pb2
+from datetime import datetime
+
+FIXTURES_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)), "fixtures")
+THIRD_PARTY_ATTRIBUTE = os.path.join(FIXTURES_DIR, "testthirdpartyattribute.txt")
+
+
+def test_should_parse_third_party_attribute_correctly():
+    thirdparty_attribute_bytes = file_helper.get_file_bytes(THIRD_PARTY_ATTRIBUTE)
+
+    proto = ThirdPartyAttribute_pb2.ThirdPartyAttribute()
+    proto.MergeFromString(thirdparty_attribute_bytes)
+
+    issuance_details = IssuanceDetails(proto)
+
+    assert issuance_details.attributes[0].name == "com.thirdparty.id"
+    assert issuance_details.token == "someIssuanceToken"
+    assert issuance_details.expiry_date == datetime(2019, 10, 15, 22, 4, 5, 123000)