SDK-1098: Update tests for checking ApplicationProfile functionality and rename some internal variables to make it more clear which profile data is which

Author: MrBurtyyy

yoti_python_sdk/client.py

@@ -84,16 +84,20 @@ def get_activity_details(self, encrypted_request_token):
             return ActivityDetails(receipt)
 
         unwrapped_key = self.__crypto.decrypt_token(receipt["wrapped_receipt_key"])
-        decrypted_data = self.__crypto.decipher(
+
+        decrypted_profile_data = self.__crypto.decipher(
             unwrapped_key, encrypted_data.iv, encrypted_data.cipher_text
         )
         decrypted_application_data = self.__crypto.decipher(
             unwrapped_key, encrypted_application_profile.iv, encrypted_application_profile.cipher_text
         )
 
-        attribute_list = proto.attribute_list(decrypted_data)
-        application_attribute_list = proto.attribute_list(decrypted_application_data)
-        return ActivityDetails(receipt, attribute_list, decrypted_application_profile=application_attribute_list)
+        user_profile_attribute_list = proto.attribute_list(decrypted_profile_data)
+        application_profile_attribute_list = proto.attribute_list(decrypted_application_data)
+
+        return ActivityDetails(
+            receipt, user_profile_attribute_list, decrypted_application_profile=application_profile_attribute_list
+        )
 
     def perform_aml_check(self, aml_profile):
         if aml_profile is None:

yoti_python_sdk/profile.py

@@ -7,6 +7,7 @@
 from yoti_python_sdk.image import Image
 from yoti_python_sdk import document_details
 
+
 class BaseProfile(object):
 
     def __init__(self, profile_attributes):
@@ -45,7 +46,8 @@ def __init__(self, profile_attributes):
                         )
 
     def get_attribute(self, attribute_name):
-        """retrieves an attribute based on its name
+        """
+        retrieves an attribute based on its name
         :param attribute_name:
         :return: Attribute
         """
@@ -194,12 +196,24 @@ def application_name(self):
 
     @property
     def application_url(self):
+        """
+        application_url is the url of the application set in Yoti Hub
+        :return: Attribute(str)
+        """
         return self.get_attribute(config.ATTRIBUTE_APPLICATION_URL)
 
     @property
     def application_logo(self):
+        """
+        application_logo is the Image of the application logo set in Yoti Hub
+        :return: Attribute(str)
+        """
         return self.get_attribute(config.ATTRIBUTE_APPLICATION_LOGO)
 
     @property
     def application_receipt_bg_color(self):
+        """
+        application_receipt_bg_color is the background color of the application set in Yoti Hub
+        :return: Attribute(str)
+        """
         return self.get_attribute(config.ATTRIBUTE_APPLICATION_RECEIPT_BGCOLOR)

yoti_python_sdk/tests/test_profile.py

@@ -7,10 +7,11 @@
 
 from yoti_python_sdk import config
 from yoti_python_sdk.attribute import Attribute
-from yoti_python_sdk.profile import Profile
+from yoti_python_sdk.profile import Profile, ApplicationProfile
 from yoti_python_sdk.protobuf.protobuf import Protobuf
 from yoti_python_sdk.tests import attribute_fixture_parser, image_helper
 from yoti_python_sdk.tests.protobuf_attribute import ProtobufAttribute
+from yoti_python_sdk.image import Image
 
 ADDRESS_FORMAT_KEY = "address_format"
 ADDRESS_FORMAT_VALUE = 1
@@ -92,6 +93,15 @@ def create_attribute_list_with_selfie_field():
     )
 
 
+def create_attribute_list_with_application_logo():
+    return create_single_attribute_list(
+        name=config.ATTRIBUTE_APPLICATION_LOGO,
+        value="base64(┛ಠ_ಠ)┛彡┻━┻",
+        anchors=None,
+        content_type=Protobuf.CT_JPEG,
+    )
+
+
 def create_attribute_list_with_email_field():
     return create_single_attribute_list(
         name=config.ATTRIBUTE_EMAIL_ADDRESS,
@@ -587,3 +597,58 @@ def test_get_document_details_india():
     assert document.issuing_country == INDIA_COUNTRY_ISO_VALUE
     assert document.document_number == IND_DRIVING_LICENCE_NUMBER
     assert document.expiration_date.isoformat() == EXPIRY_DATE
+
+
+def test_create_application_profile_with_name():
+    attribute_list = create_single_attribute_list(
+        name=config.ATTRIBUTE_APPLICATION_NAME,
+        value="yoti-sdk-test",
+        anchors=None,
+        content_type=Protobuf.CT_STRING
+    )
+
+    app_profile = ApplicationProfile(attribute_list)
+
+    assert (app_profile.get_attribute(config.ATTRIBUTE_APPLICATION_NAME) == app_profile.application_name)
+    assert isinstance(app_profile, ApplicationProfile)
+
+
+def test_create_application_profile_with_url():
+    attribute_list = create_single_attribute_list(
+        name=config.ATTRIBUTE_APPLICATION_URL,
+        value="https://yoti.com",
+        anchors=None,
+        content_type=Protobuf.CT_STRING
+    )
+
+    app_profile = ApplicationProfile(attribute_list)
+
+    assert (app_profile.get_attribute(config.ATTRIBUTE_APPLICATION_URL) == app_profile.application_url)
+    assert isinstance(app_profile, ApplicationProfile)
+
+
+def test_create_application_profile_with_receipt_bgcolor():
+    attribute_list = create_single_attribute_list(
+        name=config.ATTRIBUTE_APPLICATION_RECEIPT_BGCOLOR,
+        value="#FFFFFF",
+        anchors=None,
+        content_type=Protobuf.CT_STRING
+    )
+
+    app_profile = ApplicationProfile(attribute_list)
+
+    assert (app_profile.get_attribute(config.ATTRIBUTE_APPLICATION_RECEIPT_BGCOLOR) ==  app_profile.application_receipt_bg_color)
+    assert isinstance(app_profile, ApplicationProfile)
+
+
+def test_create_application_profile_with_logo():
+    attribute_list = create_attribute_list_with_application_logo()
+
+    app_profile = ApplicationProfile(attribute_list)
+    app_logo = app_profile.application_logo
+
+    assert isinstance(app_logo.value, Image)
+    assert (app_profile.get_attribute(config.ATTRIBUTE_APPLICATION_LOGO) == app_profile.application_logo)
+    assert isinstance(app_profile, ApplicationProfile)
+
+