Skip to content

Commit bac9ba7

Browse files
committed
fix: no violation logged on blocking validation
1 parent 664713e commit bac9ba7

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

spring-boot-starter/spring-boot-starter-web/src/main/java/com/getyourguide/openapi/validation/filter/OpenApiValidationInterceptor.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@ private List<OpenApiViolation> validateRequest(
150150
.validateRequestObjectAsync(requestMetaData, responseMetaData, requestBody, openApiViolationHandler);
151151
return List.of();
152152
} else {
153-
return validator.validateRequestObject(requestMetaData, requestBody);
153+
var violations = validator.validateRequestObject(requestMetaData, requestBody);
154+
violations.forEach(openApiViolationHandler::onOpenApiViolation);
155+
return violations;
154156
}
155157
}
156158

@@ -185,7 +187,9 @@ private List<OpenApiViolation> validateResponse(
185187
.validateResponseObjectAsync(requestMetaData, responseMetaData, responseBody, openApiViolationHandler);
186188
return List.of();
187189
} else {
188-
return validator.validateResponseObject(requestMetaData, responseMetaData, responseBody);
190+
var violations = validator.validateResponseObject(requestMetaData, responseMetaData, responseBody);
191+
violations.forEach(openApiViolationHandler::onOpenApiViolation);
192+
return violations;
189193
}
190194
}
191195

spring-boot-starter/spring-boot-starter-webflux/src/main/java/com/getyourguide/openapi/validation/filter/OpenApiValidationWebFilter.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,9 @@ private List<OpenApiViolation> validateRequest(
141141
}
142142

143143
if (runType == RunType.SYNC) {
144-
return validator.validateRequestObject(requestMetaData, responseMetaData, request.getCachedBody());
144+
var violations = validator.validateRequestObject(requestMetaData, responseMetaData, request.getCachedBody());
145+
violations.forEach(openApiViolationHandler::onOpenApiViolation);
146+
return violations;
145147
} else {
146148
validator.validateRequestObjectAsync(
147149
requestMetaData, responseMetaData, request.getCachedBody(), openApiViolationHandler);
@@ -160,7 +162,9 @@ private List<OpenApiViolation> validateResponse(
160162
}
161163

162164
if (runType == RunType.SYNC) {
163-
return validator.validateResponseObject(requestMetaData, responseMetaData, responseBody);
165+
var violations = validator.validateResponseObject(requestMetaData, responseMetaData, responseBody);
166+
violations.forEach(openApiViolationHandler::onOpenApiViolation);
167+
return violations;
164168
} else {
165169
validator
166170
.validateResponseObjectAsync(requestMetaData, responseMetaData, responseBody, openApiViolationHandler);

0 commit comments

Comments
 (0)