Skip to content

Commit 24b589b

Browse files
authored
Merge pull request #30 from getyourguide/marinofelipe-patch-1
Update conditions for summary and PR comments
2 parents 2aaa116 + 57b336b commit 24b589b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/actions/lint/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ runs:
5555
shell: /bin/bash -e {0}
5656

5757
- name: Write to workflow job summary
58-
if: ${{ inputs.adds-to-summary == 'true' }}
58+
if: ${{ always() && inputs.adds-to-summary == 'true' }}
5959
run: |
6060
lint_summary=$'# spmgraph lint\n## Results\n'
6161
echo "$lint_summary" >> $GITHUB_STEP_SUMMARY
@@ -68,15 +68,15 @@ runs:
6868
shell: /bin/bash -e {0}
6969

7070
- name: Report warnings as a PR comment
71-
if: ${{ inputs.adds-pr-comment == 'true' && steps.lint-dependency-graph.outputs.lint-failed == 'true' }}
71+
if: ${{ always() && inputs.adds-pr-comment == 'true' && steps.lint-dependency-graph.outputs.lint-failed == 'true' }}
7272
continue-on-error: true # Do not fail the workflow if the comment fails or if not a PR
7373
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
7474
with:
7575
file-path: /Users/administrator/runner/_work/iOS/iOS/lint_output.txt
7676
comment-tag: lint-report # the same across runs, which updates the comment from previous runs
7777

7878
- name: Report lint passed as a PR comment
79-
if: ${{ inputs.adds-pr-comment == 'true' && steps.lint-dependency-graph.outputs.lint-failed == 'false' }}
79+
if: ${{ always() && inputs.adds-pr-comment == 'true' && steps.lint-dependency-graph.outputs.lint-failed == 'false' }}
8080
continue-on-error: true # Do not fail the workflow if the comment fails or if not a PR
8181
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
8282
with:

0 commit comments

Comments
 (0)