Merge pull request #11 from getyourguide/TP-tax-dependency

adds getTax function

Author: scandar

src/utils/__tests__/price-calculator.test.ts

@@ -1,8 +1,10 @@
 import { calculateCartTotal } from "../price-calculator";
+// import { getTax } from "../utils/tax";
 
 describe("calculateCartTotal()", () => {
   it("calculates the total of a number of cart items", () => {
-    const total = calculateCartTotal([], 0.07);
+    const total = calculateCartTotal([]);
     expect(total).toEqual({ status: "success", total: "0.00" });
   });
-});
+});
+

src/utils/price-calculator.ts

@@ -1,3 +1,4 @@
+import { getTax } from "@/utils/tax";
 import type { CartItem } from "@/types/cart-item";
 
 /*
@@ -16,8 +17,7 @@ import type { CartItem } from "@/types/cart-item";
     name: "Product 4",
     },
   ];
-  const tax = 0.07;
-  const total = calculateCartTotal(items, tax);
+  const total = calculateCartTotal(items);
   cosole.log(total); // { status: "success", total: "38.49" }
 
 
@@ -41,18 +41,19 @@ import type { CartItem } from "@/types/cart-item";
     name: "Product 4",
     },
   ];
-  const tax = 0.07;
-  const total = calculateCartTotal(items, tax);
+  const total = calculateCartTotal(items);
   cosole.log(total); // { status: "error", message: "Cart has duplicate items" }
   */
 
   type CartTotalResult =
   | { status: "success"; total: string }
   | { status: "error"; message: string };
 
-export function calculateCartTotal(cartItems: CartItem[], tax?: number): CartTotalResult {
+export function calculateCartTotal(cartItems: CartItem[]): CartTotalResult {
+  const tax = getTax();
   return {
     status: "success",
     total: "0.00",
   };
 }
+

src/utils/tax.ts

@@ -0,0 +1,7 @@
+/**
+ * Get the tax rate
+ * In a real application, this would be fetched from an API
+ * as it changes frequently
+ * */
+export const getTax = () => 0.07;
+