Better implementation

Author: opstic

wgpu-core/src/device/resource.rs

@@ -4464,6 +4464,10 @@ impl Device {
         {
             format_features.flags.set(tfsc::FILTERABLE, false);
         }
+        format_features.allowed_usages.set(
+            wgt::TextureUsages::TRANSIENT,
+            self.features.contains(wgt::Features::TRANSIENT_ATTACHMENTS),
+        );
         format_features
     }
 

wgpu-core/src/instance.rs

@@ -706,7 +706,6 @@ impl Adapter {
             wgt::TextureUsages::STORAGE_ATOMIC,
             caps.contains(Tfc::STORAGE_ATOMIC),
         );
-        allowed_usages.set(wgt::TextureUsages::TRANSIENT, caps.contains(Tfc::TRANSIENT));
 
         let mut flags = wgt::TextureFormatFeatureFlags::empty();
         flags.set(

wgpu-hal/src/lib.rs

@@ -1675,9 +1675,6 @@ bitflags!(
         const COPY_SRC = 1 << 15;
         /// Format can be copied to.
         const COPY_DST = 1 << 16;
-
-        /// Format can be created as transient.
-        const TRANSIENT = 1 << 17;
     }
 );
 

wgpu-hal/src/metal/adapter.rs

@@ -149,7 +149,7 @@ impl crate::Adapter for super::Adapter {
             | msaa_count
             | Tfc::MULTISAMPLE_RESOLVE;
 
-        let mut extra = match format {
+        let extra = match format {
             Tf::R8Unorm | Tf::R16Float | Tf::Rgba8Unorm | Tf::Rgba16Float => {
                 read_write_tier2_if | all_caps
             }
@@ -352,11 +352,6 @@ impl crate::Adapter for super::Adapter {
             }
         };
 
-        extra.set(
-            Tfc::TRANSIENT,
-            self.shared.private_caps.supports_memoryless_storage,
-        );
-
         Tfc::COPY_SRC | Tfc::COPY_DST | Tfc::SAMPLED | Tfc::STORAGE_READ_ONLY | extra
     }
 

wgpu-hal/src/metal/device.rs

@@ -452,9 +452,7 @@ impl crate::Device for super::Device {
                 }
             };
 
-            let mtl_storage_mode = if desc.usage.contains(wgt::TextureUses::TRANSIENT)
-                && self.features.contains(wgt::Features::TRANSIENT_ATTACHMENTS)
-            {
+            let mtl_storage_mode = if desc.usage.contains(wgt::TextureUses::TRANSIENT) {
                 MTLStorageMode::Memoryless
             } else {
                 MTLStorageMode::Private

wgpu-hal/src/vulkan/adapter.rs

@@ -2446,7 +2446,7 @@ impl crate::Adapter for super::Adapter {
         };
         let features = properties.optimal_tiling_features;
 
-        let mut flags = Tfc::TRANSIENT;
+        let mut flags = Tfc::empty();
         flags.set(
             Tfc::SAMPLED,
             features.contains(vk::FormatFeatureFlags::SAMPLED_IMAGE),

wgpu-types/src/lib.rs

@@ -5666,7 +5666,7 @@ bitflags::bitflags! {
         /// Flag used by the wgpu-core texture tracker to say that the tracker does not know the state of the sub-resource.
         /// This is different from UNINITIALIZED as that says the tracker does know, but the texture has not been initialized.
         const UNKNOWN = 1 << 13;
-        /// Transient image
+        /// Transient image.
         const TRANSIENT = 1 << 14;
     }
 }