CI: Disallow all warnings in cargo deny and prune unmatched skips
#8283
Conversation
|
Here it is failing as expected: https://github.com/gfx-rs/wgpu/actions/runs/18142774695/job/51637459656?pr=8283 Also yikes: why is that reinstalling the toolchain on |
MarijnS95
changed the title
cargo denycargo deny and prune unmatched skips
The warnings right now all entail `unmatched-skip` / `unmatched-skip-root` that have (likely) gotten stale since various automated Renovate bumps where `Cargo.lock` changes don't require the corresponding unmatched duplicate to be removed from `.deny.toml` again. An exception has been made for `unmatched-organization` since we don't always have a `git` dependency on a fork in `gfx-rs`, resulting in a warning about that orga being in `sources.allow-org.github`.
If there were multiple commits in this PR, I'd understand this request, but squash-and-merging for single commits has been really helpful for contributors wanting to track where contributions came from WRT PRs. Is there a reason I shouldn't squash-and-merge this? |
|
I should have probably removed that (= my default) answer and this question entirely as the context in which it is asked is irrelevant for single-commit PRs. It really doesn't matter, and if it helps folks see the |
…gfx-rs#8283) The warnings right now all entail `unmatched-skip` / `unmatched-skip-root` that have (likely) gotten stale since various automated Renovate bumps where `Cargo.lock` changes don't require the corresponding unmatched duplicate to be removed from `.deny.toml` again. An exception has been made for `unmatched-organization` since we don't always have a `git` dependency on a fork in `gfx-rs`, resulting in a warning about that orga being in `sources.allow-org.github`.
2 participants
Connections
Split out from #6876
Description
The warnings right now all entail
unmatched-skip/unmatched-skip-rootthat have (likely) gotten stale since various automated Renovate bumps whereCargo.lockchanges don't require the corresponding unmatched duplicate to be removed from.deny.tomlagain.An exception has been made for
unmatched-organizationsince we don't always have agitdependency on a fork ingfx-rs, resulting in a warning about that orga being insources.allow-org.github.Testing
Locally:
$ cargo deny --all-features --workspace check -Dwarnings -Aunmatched-organizationSquash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.