Skip to content

Reject fragment shader output locations >= max_color_attachments limit #8316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2025
Merged

Reject fragment shader output locations >= max_color_attachments limit #8316

merged 3 commits into from
Oct 8, 2025
+133 −20

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Oct 7, 2025 •
edited
Loading

Found a spec. bug (see gpuweb/gpuweb#5341)! 😀 The WebGPU spec. didn't demand that we ensure that this was so, but it was intended to.

rebaseplz

Testing

A test has been added, named reject_fragment_shader_output_over_max_color_attachments.

Checklist

  • If this contains user-facing changes, add a CHANGELOG.md entry.

@ErichDonGubler
Copy link
Member Author

Current CI failures are unrelated, and are resolved with #8317.

@ErichDonGubler ErichDonGubler changed the title [naga] Reject fragment output locations > max_color_attachments Reject fragment output locations > max_color_attachments Oct 7, 2025
@ErichDonGubler ErichDonGubler added area: api Issues related to API surface area: correctness We're behaving incorrectly type: bug Something isn't working labels Oct 7, 2025
@ErichDonGubler ErichDonGubler changed the title Reject fragment output locations > max_color_attachments Reject fragment shader output locations > max_color_attachments Oct 7, 2025
@ErichDonGubler ErichDonGubler changed the title Reject fragment shader output locations > max_color_attachments Reject fragment shader output locations > max_color_attachments limit Oct 7, 2025
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-boinging-erudite-lemon branch from a8a62f6 to 5f9d9bc Compare October 7, 2025 19:33
@ErichDonGubler ErichDonGubler marked this pull request as ready for review October 7, 2025 19:45
andyleiserson
andyleiserson approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@andyleiserson andyleiserson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also want to impose some limits in naga in cases where large values will result in allocating big arrays for the module or interface info.

@andyleiserson andyleiserson self-assigned this Oct 8, 2025
@ErichDonGubler ErichDonGubler changed the title Reject fragment shader output locations > max_color_attachments limit Reject fragment shader output locations >= max_color_attachments limit Oct 8, 2025
@ErichDonGubler
Copy link
Member Author

ErichDonGubler commented Oct 8, 2025 •
edited
Loading

Rebasing with autosquash applied. Also editing the commit message and PR with s/>/>=/, because that needed to be changed in implementation, too.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-boinging-erudite-lemon branch from 092d0b3 to d2e2f39 Compare October 8, 2025 20:06
@ErichDonGubler ErichDonGubler enabled auto-merge (rebase) October 8, 2025 20:06
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-boinging-erudite-lemon branch from d2e2f39 to 48757bb Compare October 8, 2025 20:11
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-boinging-erudite-lemon branch from 48757bb to 7c27d48 Compare October 8, 2025 20:24
@ErichDonGubler ErichDonGubler merged commit adf4b2f into gfx-rs:trunk Oct 8, 2025
41 checks passed
@ErichDonGubler ErichDonGubler deleted the erichdongubler-push-boinging-erudite-lemon branch October 8, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleiserson andyleiserson andyleiserson approved these changes

Assignees

@andyleiserson andyleiserson

Labels
area: api Issues related to API surface area: correctness We're behaving incorrectly type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErichDonGubler @andyleiserson