Allow empty buffer slices to be created, but not used #8505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Open questions:
|
Contributor
|
Related: #3170 The WebGPU spec allows zero-size bindings in places where we currently don't. I think that answers the question of whether we should accept them, but we need to figure out how to handle them internally when the backend does not support them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAUTION!
This is a draft PR. It has not been fully tested. This code is awaiting review before it can be merged.
Connections
Addresses #6779. Some developers would like for wgpu not to panic when 0-length buffer slices exist.
Description
wgpu currently panics if an empty buffer slice (length 0) is created. The code currently has contradictory comments about whether empty buffer slices are allowed to exist or not. This PR makes it so empty buffer slices can be created, but not mapped or referenced by
set_index_bufferorset_vertex_buffer.Testing
Tests in buffer.rs have been modified to accept zero-length buffer slices. All tests pass.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.