Docstrings,type hints for public items.#3
Open
alchemistcai wants to merge 1 commit intogfzhou:mainfrom
Open
Conversation
alchemistcai
force-pushed
the
docstring_type_hints
branch
from
ab5f1e5 to
4a6467a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openvs,classes, variables and functions.If some are never used,skip them.openvs. If some are never used,skip them.set()instead ofset([]).dict.items()when keys and values are used.Avoid twice key search..gitignoreto ignore pycaches and egg-infos.(0.2,0.35,0.5)instead of[0.2,0.35,0.5]as functions' default parameter.Docstrings and type hints are inferred manually.So they need reviews.