Replace caddy replacer by request context replacer

Author: Thibaut Cholley

jwt.go

@@ -300,11 +300,12 @@ func (ja *JWTAuth) validateSignatureKeys() error {
 	return nil
 }
 
-func (ja *JWTAuth) keyProvider() jws.KeyProviderFunc {
+func (ja *JWTAuth) keyProvider(request *http.Request) jws.KeyProviderFunc {
 	return func(context context.Context, sink jws.KeySink, sig *jws.Signature, _ *jws.Message) error {
 		if ja.usingJWK() {
 			// Resolve JWKURL with placeholders
-			resolvedURL := caddy.NewReplacer().ReplaceAll(ja.JWKURL, "")
+			replacer := request.Context().Value(caddy.ReplacerCtxKey).(*caddy.Replacer)
+			resolvedURL := replacer.ReplaceAll(ja.JWKURL, "")
 
 			ja.logger.Info("JWK unresolved", zap.String("placeholder_url", ja.JWKURL))
 			ja.logger.Info("JWK resolved", zap.String("placeholder_url", resolvedURL))
@@ -376,7 +377,7 @@ func (ja *JWTAuth) Authenticate(rw http.ResponseWriter, r *http.Request) (User,
 			jwt.WithVerify(!ja.SkipVerification),
 		}
 		if !ja.SkipVerification {
-			jwtOptions = append(jwtOptions, jwt.WithKeyProvider(ja.keyProvider()))
+			jwtOptions = append(jwtOptions, jwt.WithKeyProvider(ja.keyProvider(r)))
 		}
 		gotToken, err = jwt.ParseString(tokenString, jwtOptions...)
 

jwt_test.go

@@ -1,11 +1,13 @@
 package caddyjwt
 
 import (
+	"context"
 	"crypto/ed25519"
 	"crypto/rand"
 	"crypto/rsa"
 	"encoding/base64"
 	"encoding/json"
+	"github.com/caddyserver/caddy/v2"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
@@ -788,6 +790,11 @@ func TestJWK(t *testing.T) {
 	token := issueTokenStringJWK(MapClaims{"sub": "ggicci"})
 	rw := httptest.NewRecorder()
 	r, _ := http.NewRequest("GET", "/", nil)
+
+	repl := caddy.NewReplacer()
+	ctx := context.WithValue(r.Context(), caddy.ReplacerCtxKey, repl)
+	r = r.WithContext(ctx)
+
 	r.Header.Add("Authorization", "Bearer "+token)
 	gotUser, authenticated, err := ja.Authenticate(rw, r)
 	assert.Nil(t, err)
@@ -811,6 +818,11 @@ func TestJWKSet(t *testing.T) {
 	token := issueTokenStringJWK(MapClaims{"sub": "ggicci"})
 	rw := httptest.NewRecorder()
 	r, _ := http.NewRequest("GET", "/", nil)
+
+	repl := caddy.NewReplacer()
+	ctx := context.WithValue(r.Context(), caddy.ReplacerCtxKey, repl)
+	r = r.WithContext(ctx)
+
 	r.Header.Add("Authorization", "Bearer "+token)
 	gotUser, authenticated, err := ja.Authenticate(rw, r)
 	assert.Nil(t, err)
@@ -834,6 +846,11 @@ func TestJWKSet_KeyNotFound(t *testing.T) {
 	token := issueTokenStringJWK(MapClaims{"sub": "ggicci"})
 	rw := httptest.NewRecorder()
 	r, _ := http.NewRequest("GET", "/", nil)
+
+	repl := caddy.NewReplacer()
+	ctx := context.WithValue(r.Context(), caddy.ReplacerCtxKey, repl)
+	r = r.WithContext(ctx)
+
 	r.Header.Add("Authorization", "Bearer "+token)
 	gotUser, authenticated, err := ja.Authenticate(rw, r)