Edit comment to clarify issue

city96 · JohannesGaessler · web-flow · commit 06113f00273e · 2025-04-25T12:58:48.000+02:00
Co-authored-by: Johannes Gäßler &lt;johannesg@5d6.de&gt;
diff --git a/src/llama-graph.cpp b/src/llama-graph.cpp
@@ -804,7 +804,7 @@ ggml_tensor * llm_graph_context::build_ffn(
     if (down) {
         cur = build_lora_mm(down, cur);
         if (arch == LLM_ARCH_GLM4) {
-            // GLM4 seems to have precision issues in F16
+            // GLM4 seems to have numerical issues with half-precision accumulators
             ggml_mul_mat_set_prec(cur, GGML_PREC_F32);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -804,7 +804,7 @@ ggml_tensor * llm_graph_context::build_ffn(`
`804`	`804`	`if (down) {`
`805`	`805`	`cur = build_lora_mm(down, cur);`
`806`	`806`	`if (arch == LLM_ARCH_GLM4) {`
`807`		`- // GLM4 seems to have precision issues in F16`
	`807`	`+ // GLM4 seems to have numerical issues with half-precision accumulators`
`808`	`808`	`ggml_mul_mat_set_prec(cur, GGML_PREC_F32);`
`809`	`809`	`}`
`810`	`810`	`}`