do not return if cannot parse metadata json

ngxson · ngxson · commit 18c793df0e8d · 2025-04-30T19:25:45.000+02:00
diff --git a/common/arg.cpp b/common/arg.cpp
@@ -295,7 +295,6 @@ static bool common_download_file_single(const std::string & url, const std::stri
                 }
             } catch (const nlohmann::json::exception & e) {
                 LOG_ERR("%s: error reading metadata file %s: %s\n", __func__, metadata_path.c_str(), e.what());
-                return false;
             }
         }
         // if we cannot open the metadata file, we assume that the downloaded file is not valid (etag and last-modified are left empty, so we will download it again)

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,6 @@ static bool common_download_file_single(const std::string & url, const std::stri`
`295`	`295`	`}`
`296`	`296`	`} catch (const nlohmann::json::exception & e) {`
`297`	`297`	`LOG_ERR("%s: error reading metadata file %s: %s\n", __func__, metadata_path.c_str(), e.what());`
`298`		`- return false;`
`299`	`298`	`}`
`300`	`299`	`}`
`301`	`300`	`// if we cannot open the metadata file, we assume that the downloaded file is not valid (etag and last-modified are left empty, so we will download it again)`