remove memset that causes buffer overflow

ngxson · ngxson · commit 2ab608b15267 · 2025-02-08T22:19:44.000+01:00
Co-authored-by: camel-cdr &lt;camel-cdr@protonmail.com&gt;
diff --git a/ggml/src/ggml-cpu/ggml-cpu-quants.c b/ggml/src/ggml-cpu/ggml-cpu-quants.c
@@ -1674,11 +1674,10 @@ void quantize_row_q8_K(const float * restrict x, void * restrict y, int64_t k) {
             for (int j = 0; j < QK_K; j += 16) {
                 wasm_v128_store(yc[i].qs + j, zero);
             }
-            memset(yc[i].bsums, 0, QK_K/16 * sizeof(int));
             continue;
         }
 
-        const float iscale = -127.0f / max_val;
+        const float iscale = -127.0f / amax;
         const v128_t scale_vec = wasm_f32x4_splat(iscale);
 
         // Process 16 elements per iteration

Original file line number	Diff line number	Diff line change
`@@ -1674,11 +1674,10 @@ void quantize_row_q8_K(const float * restrict x, void * restrict y, int64_t k) {`
`1674`	`1674`	`for (int j = 0; j < QK_K; j += 16) {`
`1675`	`1675`	`wasm_v128_store(yc[i].qs + j, zero);`
`1676`	`1676`	`}`
`1677`		`- memset(yc[i].bsums, 0, QK_K/16 * sizeof(int));`
`1678`	`1677`	`continue;`
`1679`	`1678`	`}`
`1680`	`1679`
`1681`		`- const float iscale = -127.0f / max_val;`
	`1680`	`+ const float iscale = -127.0f / amax;`
`1682`	`1681`	`const v128_t scale_vec = wasm_f32x4_splat(iscale);`
`1683`	`1682`
`1684`	`1683`	`// Process 16 elements per iteration`