Skip to content

Commit 2b86342

Browse files
author
zhouwg
committed
ggml-qnn: remove no-needed comments
1 parent 7b2d3bc commit 2b86342

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ggml/src/ggml-qnn/ggml-qnn-ops.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,16 +232,16 @@ void ggml_qnn_general_node(ggml_backend_qnn_context * ctx, ggml_tensor * op) {
232232
#endif
233233
}
234234

235-
//TODO:there is issue in this function
236235
/*
237-
* this function is AI-assisted code from Grok 3 for purpose of 4d mulmat UT in ggml-qnn-ut.cpp
236+
* this function is AI-assisted code from Grok 3 for purpose of offload 4d matrix mulmat to QNN backend
237+
* UT in ggml-qnn-ut.cpp passed:
238238
* ./scripts/build-run-android.sh run_ut_mulmat 0
239239
* ./scripts/build-run-android.sh run_ut_mulmat 1
240240
* ./scripts/build-run-android.sh run_ut_mulmat 2
241241
*
242242
* the logic of ggml_qnn_mul_mat_4d is similar to ggml_qnn_mul_mat but much more complicated
243243
* than ggml_qnn_mul_mat, so it's a standalone function.
244-
* it will be combined with ggml_qnn_mul_mat after bugfix
244+
* it will be combined with ggml_qnn_mul_mat in the future
245245
*/
246246
static void ggml_qnn_mul_mat_4d(ggml_backend_qnn_context *ctx, ggml_tensor *op) {
247247
Qnn_ErrorHandle_t error = QNN_SUCCESS;

ggml/src/ggml-qnn/ggml-qnn.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2277,7 +2277,7 @@ static bool ggml_qnn_can_handle_op(const ggml_backend_qnn_context * ctx, const s
22772277
return false;
22782278
if (src0_rank < 2) // QNN's limitation, make QNN SDK happy
22792279
return false;
2280-
if (4 == src0_rank) //TODO: 4D matrix mulmat
2280+
if (4 == src0_rank) //TODO: 4D matrix mulmat in CT
22812281
return false;
22822282
if ((src1->ne[2] != src0->ne[2]) || (src1->ne[3] != src0->ne[3])) // make QNN SDK happy
22832283
return false;

0 commit comments

Comments
 (0)