Skip to content

Commit 2bd2a5a

Browse files
committed
Apply review suggestions: cleanup formatting, enum order and leftover artifacts
1 parent f340abc commit 2bd2a5a

File tree

4 files changed

+2
-11
lines changed

4 files changed

+2
-11
lines changed

docs/ops.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,7 @@ Legend:
110110
| SWIGLU_OAI ||||||||||
111111
| TANH |||| 🟡 | 🟡 || 🟡 | 🟡 ||
112112
| TIMESTEP_EMBEDDING ||||||||||
113-
114113
| TRUNC ||||||||||
115-
116114
| TOPK_MOE ||||||||||
117-
118115
| UPSCALE || 🟡 ||| 🟡 || 🟡 |||
119116
| XIELU ||||||||||

ggml/include/ggml.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,12 +576,11 @@ extern "C" {
576576
GGML_UNARY_OP_HARDSIGMOID,
577577
GGML_UNARY_OP_EXP,
578578
GGML_UNARY_OP_GELU_ERF,
579+
GGML_UNARY_OP_XIELU,
579580
GGML_UNARY_OP_FLOOR,
580581
GGML_UNARY_OP_CEIL,
581582
GGML_UNARY_OP_ROUND,
582583
GGML_UNARY_OP_TRUNC,
583-
GGML_UNARY_OP_XIELU,
584-
585584

586585
GGML_UNARY_OP_COUNT,
587586
};

ggml/src/ggml-cpu/ops.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9008,11 +9008,10 @@ void ggml_compute_forward_unary(
90089008
case GGML_UNARY_OP_TRUNC:
90099009
{
90109010
ggml_compute_forward_trunc(params, dst);
9011-
9011+
} break;
90129012
case GGML_UNARY_OP_XIELU:
90139013
{
90149014
ggml_compute_forward_xielu(params, dst);
9015-
90169015
} break;
90179016
default:
90189017
{

ggml/src/ggml-cpu/unary-ops.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ void ggml_compute_forward_round(const struct ggml_compute_params * params, struc
2828
void ggml_compute_forward_trunc(const struct ggml_compute_params * params, struct ggml_tensor * dst);
2929
void ggml_compute_forward_xielu(const struct ggml_compute_params * params, struct ggml_tensor * dst);
3030

31-
32-
33-
34-
3531
#ifdef __cplusplus
3632
}
3733
#endif

0 commit comments

Comments
 (0)