Skip to content

Commit 2e656f9

Browse files
author
ochafik
committed
improve "bad" qwen triggers
1 parent 6fd4972 commit 2e656f9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

common/chat.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1383,11 +1383,6 @@ static common_chat_params common_chat_params_init_hermes_2_pro(const common_chat
13831383
COMMON_GRAMMAR_TRIGGER_TYPE_PATTERN,
13841384
"<function\\s+name\\s*=\\s*\"" + escaped_name + "\"",
13851385
});
1386-
// Trigger on some common known "good bad" outputs (only from the start and with a json that's about a specific argument name to avoid false positives)
1387-
data.grammar_triggers.push_back({
1388-
COMMON_GRAMMAR_TRIGGER_TYPE_PATTERN_START,
1389-
"(?:<function_call>|<tools>|<xml><json>|<response>)?(?:```(?:json|xml)?\n)?\\s*\\{\\s*\"name\"\\s*:\\s*\"" + escaped_name + "\"",
1390-
});
13911386
});
13921387
auto any_tool_call = builder.add_rule("any_tool_call", "( " + string_join(tool_rules, " | ") + " ) space");
13931388
std::vector<std::string> alt_tags {
@@ -1409,6 +1404,11 @@ static common_chat_params common_chat_params_init_hermes_2_pro(const common_chat
14091404
builder.add_rule("root", inputs.parallel_tool_calls ? "(" + tool_call + ")+" : tool_call);
14101405
data.grammar_triggers.push_back({COMMON_GRAMMAR_TRIGGER_TYPE_WORD, "<tool_call>"});
14111406
data.grammar_triggers.push_back({COMMON_GRAMMAR_TRIGGER_TYPE_WORD, "<function"});
1407+
// Trigger on some common known "good bad" outputs (only from the start and with a json that's about a specific argument name to avoid false positives)
1408+
data.grammar_triggers.push_back({
1409+
COMMON_GRAMMAR_TRIGGER_TYPE_PATTERN_START,
1410+
"(?:```(?:json|xml)?\n\\s*)?(?:<function_call>|<tools>|<xml><json>|<response>)?\\s*\\{\\s*\"", //name\"\\s*:\\s*\"" + escaped_name + "\"",
1411+
});
14121412
data.preserved_tokens = {
14131413
"<tool_call>",
14141414
"</tool_call>",

0 commit comments

Comments
 (0)