test groups of common_chat_msg_parser.try_consume_regex

Author: ochafik

tests/test-chat-parser.cpp

@@ -126,7 +126,13 @@ static void test_regex() {
   }
   {
     common_chat_msg_parser builder("Hello,", /* is_partial= */ false, {});
-    assert_equals(true, builder.try_consume_regex(common_regex("Hell(o, world!)?")).has_value());
+    auto res = builder.try_consume_regex(common_regex("H(el)l(?:o, world!)?"));
+    assert_equals(true, res.has_value());
+    // Verify captures
+    assert_equals<size_t>(2, res->groups.size());
+    assert_equals("Hell", builder.str(res->groups[0]));
+    assert_equals("el", builder.str(res->groups[1]));
+    // Verify position is after the match
     assert_equals<size_t>(4, builder.pos());
     assert_equals("o,", builder.consume_rest());
   }

tests/test-regex-partial.cpp

@@ -25,7 +25,7 @@ struct test_case {
 };
 
 static void test_regex() {
-
+    printf("[%s]\n", __func__);
     auto test = [](const test_case & test_case) {
         common_regex cr(test_case.pattern);
         std::cout << "Testing pattern: /" << test_case.pattern << "/\n";
@@ -152,6 +152,7 @@ static void test_regex() {
 }
 
 static void test_regex_to_reversed_partial_regex() {
+    printf("[%s]\n", __func__);
     assert_equals<std::string>(
         "(a+).*",
         regex_to_reversed_partial_regex("a+"));
@@ -199,12 +200,7 @@ static void test_regex_to_reversed_partial_regex() {
 }
 
 int main() {
-    try {
-        test_regex_to_reversed_partial_regex();
-        test_regex();
-    } catch (const std::exception & e) {
-        std::cerr << "Test failed: " << e.what() << '\n';
-        return 1;
-    }
+    test_regex_to_reversed_partial_regex();
+    test_regex();
     std::cout << "All tests passed.\n";
 }