speculative : fix out-of-bounds access

ggerganov · ggerganov · commit 33bdee667e96 · 2024-11-14T11:23:45.000+02:00
diff --git a/examples/speculative/speculative.cpp b/examples/speculative/speculative.cpp
@@ -267,11 +267,12 @@ int main(int argc, char ** argv) {
                         for (size_t i = 0; i < dist_tgt.size; i++) {
                             if (dist_tgt.data[i].id == drafts[s].tokens[i_dft]) {
                                 p_tgt = dist_tgt.data[i].p;
+                                break;
                             }
+                        }
+                        for (size_t i = 0; i < dist_dft.size; i++) {
                             if (dist_dft.data[i].id == drafts[s].tokens[i_dft]) {
                                 p_dft = dist_dft.data[i].p;
-                            }
-                            if (p_tgt && p_dft) {
                                 break;
                             }
                         }

Original file line number	Diff line number	Diff line change
`@@ -267,11 +267,12 @@ int main(int argc, char ** argv) {`
`267`	`267`	`for (size_t i = 0; i < dist_tgt.size; i++) {`
`268`	`268`	`if (dist_tgt.data[i].id == drafts[s].tokens[i_dft]) {`
`269`	`269`	`p_tgt = dist_tgt.data[i].p;`
	`270`	`+ break;`
`270`	`271`	`}`
	`272`	`+ }`
	`273`	`+ for (size_t i = 0; i < dist_dft.size; i++) {`
`271`	`274`	`if (dist_dft.data[i].id == drafts[s].tokens[i_dft]) {`
`272`	`275`	`p_dft = dist_dft.data[i].p;`
`273`		`- }`
`274`		`- if (p_tgt && p_dft) {`
`275`	`276`	`break;`
`276`	`277`	`}`
`277`	`278`	`}`