common : disable KV cache shifting automatically for unsupported models (#11053)

MollySophia · ggerganov · web-flow · commit 4b0c638b9a68 · 2025-01-03T14:13:18.000+02:00
* Disable KV cache shifting automatically for unsupported models

instead of exiting directly

Signed-off-by: Molly Sophia &lt;mollysophia379@gmail.com&gt;

* Update common/common.cpp

Co-authored-by: Georgi Gerganov &lt;ggerganov@gmail.com&gt;

---------

Signed-off-by: Molly Sophia &lt;mollysophia379@gmail.com&gt;
Co-authored-by: Georgi Gerganov &lt;ggerganov@gmail.com&gt;
diff --git a/common/common.cpp b/common/common.cpp
@@ -889,9 +889,8 @@ struct common_init_result common_init_from_params(common_params & params) {
     }
 
     if (params.ctx_shift && !llama_kv_cache_can_shift(lctx)) {
-        LOG_ERR("%s: KV cache shifting is not supported for this model (--no-context-shift to disable)'\n", __func__);
-        llama_free_model(model);
-        return iparams;
+        LOG_WRN("%s: KV cache shifting is not supported for this model, disabling KV cache shifting\n", __func__);
+        params.ctx_shift = false;
     }
 
     if (!params.control_vectors.empty()) {

Original file line number	Diff line number	Diff line change
`@@ -889,9 +889,8 @@ struct common_init_result common_init_from_params(common_params & params) {`
`889`	`889`	`}`
`890`	`890`
`891`	`891`	`if (params.ctx_shift && !llama_kv_cache_can_shift(lctx)) {`
`892`		`- LOG_ERR("%s: KV cache shifting is not supported for this model (--no-context-shift to disable)'\n", __func__);`
`893`		`- llama_free_model(model);`
`894`		`- return iparams;`
	`892`	`+ LOG_WRN("%s: KV cache shifting is not supported for this model, disabling KV cache shifting\n", __func__);`
	`893`	`+ params.ctx_shift = false;`
`895`	`894`	`}`
`896`	`895`
`897`	`896`	`if (!params.control_vectors.empty()) {`