chat-parser: address pr-16394 review feedback from ngxson

ServeurpersoCom · ngxson · ServeurpersoCom · commit 6041e2562fd4 · 2025-10-06T20:15:41.000+02:00
Co-authored-by: Xuan Son Nguyen &lt;thichthat@gmail.com&gt;
diff --git a/common/chat-parser.cpp b/common/chat-parser.cpp
@@ -192,10 +192,6 @@ bool common_chat_msg_parser::try_parse_reasoning(const std::string & start_think
             if (!rest.empty()) {
                 handle_reasoning(rest, /* closed */ !is_partial());
             }
-            // Allow unclosed thinking tags, for now (https://github.com/ggml-org/llama.cpp/issues/13812, https://github.com/ggml-org/llama.cpp/issues/13877)
-            // if (!syntax_.thinking_forced_open) {
-            //     throw common_chat_msg_partial_exception(end_think);
-            // }
             return true;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -192,10 +192,6 @@ bool common_chat_msg_parser::try_parse_reasoning(const std::string & start_think`
`192`	`192`	`if (!rest.empty()) {`
`193`	`193`	`handle_reasoning(rest, /* closed */ !is_partial());`
`194`	`194`	`}`
`195`		`- // Allow unclosed thinking tags, for now (https://github.com/ggml-org/llama.cpp/issues/13812, https://github.com/ggml-org/llama.cpp/issues/13877)`
`196`		`- // if (!syntax_.thinking_forced_open) {`
`197`		`- // throw common_chat_msg_partial_exception(end_think);`
`198`		`- // }`
`199`	`195`	`return true;`
`200`	`196`	`}`
`201`	`197`	`}`