Hip: Supress transformation warning in softmax.cu, loops with bounds not known at compiletime indeed can not be unrolled.

IMbackK · IMbackK · commit 6505fc2fe300 · 2025-01-28T21:42:42.000+01:00
diff --git a/ggml/src/ggml-cuda/softmax.cu b/ggml/src/ggml-cuda/softmax.cu
@@ -13,6 +13,8 @@ __device__ float __forceinline__ t2f32<half>(half val) {
     return __half2float(val);
 }
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wpass-failed"
 template <bool use_shared, int ncols_template, int block_size_template, typename T>
 static __global__ void soft_max_f32(
         const float * x, const T * mask, float * dst, const int ncols_par, const int nrows_y,
@@ -118,6 +120,7 @@ static __global__ void soft_max_f32(
         dst[col] = vals[col] * inv_sum;
     }
 }
+#pragma clang diagnostic pop
 
 static __global__ void soft_max_back_f32(
         const float * grad, const float * dstf, float * dst, const int ncols, const float scale) {

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@ __device__ float __forceinline__ t2f32<half>(half val) {`
`13`	`13`	`return __half2float(val);`
`14`	`14`	`}`
`15`	`15`
	`16`	`+#pragma clang diagnostic push`
	`17`	`+#pragma clang diagnostic ignored "-Wpass-failed"`
`16`	`18`	`template <bool use_shared, int ncols_template, int block_size_template, typename T>`
`17`	`19`	`static __global__ void soft_max_f32(`
`18`	`20`	`const float * x, const T * mask, float * dst, const int ncols_par, const int nrows_y,`
`@@ -118,6 +120,7 @@ static __global__ void soft_max_f32(`
`118`	`120`	`dst[col] = vals[col] * inv_sum;`
`119`	`121`	`}`
`120`	`122`	`}`
	`123`	`+#pragma clang diagnostic pop`
`121`	`124`
`122`	`125`	`static __global__ void soft_max_back_f32(`
`123`	`126`	`const float * grad, const float * dstf, float * dst, const int ncols, const float scale) {`