Skip to content

Commit 7505ca8

Browse files
committed
ggml-zdnn: code cleanup
Signed-off-by: Aaron Teo <[email protected]>
1 parent c7e7be7 commit 7505ca8

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

ggml/src/ggml-zdnn/ggml-zdnn.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,14 @@ static void ggml_zdnn_compute_forward_mul_mat(
2020
const ggml_tensor * src1 = dst->src[1]; // inputs
2121

2222
// TODO: implement support for quantized types
23+
// we currently only support f32, f16, and bf16
2324
ggml_zdnn_mul_mat_f(ctx, src0, src1, dst);
2425
}
2526

26-
static bool ggml_zdnn_compute_forward(ggml_backend_zdnn_context * ctx, ggml_tensor * dst) {
27+
static bool ggml_zdnn_compute_forward(
28+
ggml_backend_zdnn_context * ctx,
29+
ggml_tensor * dst) {
30+
2731
switch (dst->op) {
2832
case GGML_OP_MUL_MAT:
2933
{

ggml/src/ggml-zdnn/utils.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ zdnn_data_types ggml_zdnn_type_mapping(ggml_type type) {
2323
}
2424

2525
void ggml_zdnn_create_tensor(zdnn_tensor_desc & pre_tfm_desc,
26-
zdnn_tensor_desc & tfm_desc,
27-
zdnn_ztensor & ztensor,
28-
const ggml_tensor * src,
29-
const int64_t * ne,
30-
const zdnn_data_layouts layout) {
26+
zdnn_tensor_desc & tfm_desc,
27+
zdnn_ztensor & ztensor,
28+
const ggml_tensor * src,
29+
const int64_t * ne,
30+
const zdnn_data_layouts layout) {
3131
zdnn_init_pre_transformed_desc(
3232
layout,
3333
ggml_zdnn_type_mapping(src->type),

ggml/src/ggml-zdnn/utils.hpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55

66
zdnn_data_types ggml_zdnn_type_mapping(ggml_type type);
77

8-
void ggml_zdnn_create_tensor(zdnn_tensor_desc & pre_tfm_desc,
9-
zdnn_tensor_desc & tfm_desc,
10-
zdnn_ztensor & ztensor,
11-
const ggml_tensor * src,
12-
const int64_t * ne,
13-
const zdnn_data_layouts layout);
8+
void ggml_zdnn_create_tensor(zdnn_tensor_desc & pre_tfm_desc,
9+
zdnn_tensor_desc & tfm_desc,
10+
zdnn_ztensor & ztensor,
11+
const ggml_tensor * src,
12+
const int64_t * ne,
13+
const zdnn_data_layouts layout);
1414

1515
void ggml_zdnn_load_tensor(zdnn_ztensor & ztensor, void * buffer);
1616

0 commit comments

Comments
 (0)