improve

Author: ngxson

tools/mtmd/clip.cpp

@@ -761,11 +761,12 @@ struct clip_graph {
             ggml_set_name(window_mask, "window_mask");
             ggml_set_input(window_mask);
 
-            // if flash attn is used, we need to pad the mask
+            // if flash attn is used, we need to pad the mask and cast to f16
             if (ctx->flash_attn_type == CLIP_FLASH_ATTN_TYPE_ENABLED) {
-                int padded_nrow = GGML_PAD(window_mask->ne[1], GGML_KQ_MASK_PAD);
-                window_mask = ggml_pad(ctx0, window_mask,
-                    0, padded_nrow - window_mask->ne[0], 0, 0);
+                int n_pad = GGML_PAD(window_mask->ne[1], GGML_KQ_MASK_PAD) - window_mask->ne[1];
+                if (n_pad > 0) {
+                    window_mask = ggml_pad(ctx0, window_mask, 0, n_pad, 0, 0);
+                }
                 window_mask = ggml_cast(ctx0, window_mask, GGML_TYPE_F16);
             }