don't munmap in numa in destructor

dbsanfte · dbsanfte · commit 7faf58ac33c5 · 2025-07-30T14:51:20.000+01:00
diff --git a/src/llama-mmap.cpp b/src/llama-mmap.cpp
@@ -496,8 +496,8 @@ struct llama_mmap::impl {
                               mapping.path.c_str(), strerror(errno));
             }
         }
-#endif
-#ifndef GGML_NUMA_MIRROR
+#else
+        // Only unmap fragments if not using NUMA mirroring
         for (const auto & frag : mapped_fragments) {
             if (munmap((char *) addr + frag.first, frag.second - frag.first)) {
                 LLAMA_LOG_WARN("warning: munmap failed: %s\n", strerror(errno));

Original file line number	Diff line number	Diff line change
`@@ -496,8 +496,8 @@ struct llama_mmap::impl {`
`496`	`496`	`mapping.path.c_str(), strerror(errno));`
`497`	`497`	`}`
`498`	`498`	`}`
`499`		`-#endif`
`500`		`-#ifndef GGML_NUMA_MIRROR`
	`499`	`+#else`
	`500`	`+ // Only unmap fragments if not using NUMA mirroring`
`501`	`501`	`for (const auto & frag : mapped_fragments) {`
`502`	`502`	`if (munmap((char *) addr + frag.first, frag.second - frag.first)) {`
`503`	`503`	`LLAMA_LOG_WARN("warning: munmap failed: %s\n", strerror(errno));`