Skip to content

Commit 847da1a

Browse files
committed
Always apply Eliminate_ZP to fix GPU compile issue on some platforms
1 parent 2e1dd8d commit 847da1a

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ggml/src/ggml-openvino/openvino/pass/eliminate_zp.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ EliminateZeroPoints::EliminateZeroPoints() {
8080

8181
std::shared_ptr<ov::op::v0::Constant> new_constant;
8282

83+
// TODO improve performance
8384
if (data_type == ov::element::u4) {
8485
auto data_values = data_constant->cast_vector<uint8_t>();
8586
std::vector<int8_t> adjusted_values(total_elements);

ggml/src/ggml-openvino/openvino/translate_session.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,9 +233,9 @@ std::shared_ptr<Model> TranslateSession::apply_transformations(std::shared_ptr<M
233233
manager.register_pass<ov::pass::MakeStateful>(kv_param_res_pairs);
234234
}
235235

236-
if (ggml_model_decoder->is_static()) {
237-
manager.register_pass<pass::EliminateZeroPoints>();
238-
}
236+
// if (ggml_model_decoder->is_static()) {
237+
manager.register_pass<pass::EliminateZeroPoints>();
238+
// }
239239
manager.run_passes(model);
240240
}
241241
return model;

0 commit comments

Comments
 (0)