Skip to content

Commit 8ccefe5

Browse files
committed
fix tests (they had incorrect tool call end tag)
1 parent 3ca03c7 commit 8ccefe5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/test-chat.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@ static void test_template_output_parsers() {
821821
"{\"name\": \"special_function\", \"parameters\": {\"arg1\": 1}}");
822822
}
823823
{
824-
auto tmpls = read_templates("models/templates/microsoft-Phi-4-mini-instruct.jinja");
824+
auto tmpls = read_templates("models/templates/llama-cpp-microsoft-Phi-4-mini-instruct.jinja");
825825
std::vector<std::string> end_tokens{ "<|end|>" };
826826

827827
assert_equals(COMMON_CHAT_FORMAT_PHI_4, common_chat_templates_apply(tmpls.get(), inputs_tools).format);
@@ -833,21 +833,21 @@ static void test_template_output_parsers() {
833833
assert_msg_equals(
834834
common_chat_msg{"assistant", "I'll help with that.", {}, tool_calls, "", "", ""},
835835
common_chat_parse(
836-
"I'll help with that.<|tool_call|>{\"name\":\"special_function\",\"arguments\":{\"arg1\":1}}</|tool_call|>",
836+
"I'll help with that.<|tool_call|>{\"name\":\"special_function\",\"arguments\":{\"arg1\":1}}<|/tool_call|>",
837837
COMMON_CHAT_FORMAT_PHI_4));
838838

839839
// Test with content after tool call
840840
assert_msg_equals(
841841
common_chat_msg{"assistant", "I'll help with that.", {}, tool_calls, "", "", ""},
842842
common_chat_parse(
843-
"<|tool_call|>{\"name\":\"special_function\",\"arguments\":{\"arg1\":1}}</|tool_call|>I'll help with that.",
843+
"<|tool_call|>{\"name\":\"special_function\",\"arguments\":{\"arg1\":1}}<|/tool_call|>I'll help with that.",
844844
COMMON_CHAT_FORMAT_PHI_4));
845845

846846
// Test with newlines.
847847
assert_msg_equals(message_assist_call, common_chat_parse(
848848
"<|tool_call|>\n"
849849
"{\"name\": \"special_function\", \"arguments\": {\"arg1\": 1}}\n"
850-
"</|tool_call|>",
850+
"<|/tool_call|>",
851851
COMMON_CHAT_FORMAT_PHI_4));
852852
}
853853
{

0 commit comments

Comments
 (0)