Review: early exit if col!=0

am17an · am17an · commit 933435779e1a · 2025-06-22T02:28:09.000+08:00
diff --git a/ggml/src/ggml-cuda/common.cuh b/ggml/src/ggml-cuda/common.cuh
@@ -375,9 +375,11 @@ static __global__ void reduce_rows_f32(const float * x, float * dst, const int n
 
     sum = warp_reduce_sum(sum);
 
-    if (col == 0) {
-        dst[row] = norm ? sum / ncols : sum;
+    if (col != 0) {
+        return;
     }
+
+    dst[row] = norm ? sum / ncols : sum;
 }
 
 template<int width = WARP_SIZE>

Original file line number	Diff line number	Diff line change
`@@ -375,9 +375,11 @@ static __global__ void reduce_rows_f32(const float * x, float * dst, const int n`
`375`	`375`
`376`	`376`	`sum = warp_reduce_sum(sum);`
`377`	`377`
`378`		`- if (col == 0) {`
`379`		`- dst[row] = norm ? sum / ncols : sum;`
	`378`	`+ if (col != 0) {`
	`379`	`+ return;`
`380`	`380`	`}`
	`381`	`+`
	`382`	`+ dst[row] = norm ? sum / ncols : sum;`
`381`	`383`	`}`
`382`	`384`
`383`	`385`	`template<int width = WARP_SIZE>`