Skip to content

Commit 95da850

Browse files
IMbackKam17an
authored andcommitted
HIP: fix hipStreamWaitEvent define and nodiscard warnings
1 parent f61bb61 commit 95da850

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

ggml/src/ggml-cuda/common.cuh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include <cfloat>
2626
#include <cstdio>
2727
#include <string>
28+
#include <unordered_map>
2829
#include <vector>
2930

3031
#if defined(GGML_USE_HIP)
@@ -974,11 +975,11 @@ struct ggml_cuda_concurrent_event {
974975
per_stream_events.resize(n_streams);
975976

976977
for (size_t i = 0; i < per_stream_events.size(); ++i) {
977-
cudaEventCreateWithFlags(&per_stream_events[i], cudaEventDisableTiming);
978+
CUDA_CHECK(cudaEventCreateWithFlags(&per_stream_events[i], cudaEventDisableTiming));
978979
}
979980

980-
cudaEventCreateWithFlags(&fork_event, cudaEventDisableTiming);
981-
cudaEventCreateWithFlags(&join_event, cudaEventDisableTiming);
981+
CUDA_CHECK(cudaEventCreateWithFlags(&fork_event, cudaEventDisableTiming));
982+
CUDA_CHECK(cudaEventCreateWithFlags(&join_event, cudaEventDisableTiming));
982983
}
983984
};
984985

ggml/src/ggml-cuda/vendors/hip.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
#define cudaStreamNonBlocking hipStreamNonBlocking
106106
#define cudaStreamPerThread hipStreamPerThread
107107
#define cudaStreamSynchronize hipStreamSynchronize
108-
#define cudaStreamWaitEvent(stream, event, flags) hipStreamWaitEvent(stream, event, flags)
108+
#define cudaStreamWaitEvent hipStreamWaitEvent
109109
#define cudaGraphExec_t hipGraphExec_t
110110
#define cudaGraphNode_t hipGraphNode_t
111111
#define cudaKernelNodeParams hipKernelNodeParams

0 commit comments

Comments
 (0)