string utils: use string_views

Author: ochafik

common/common.cpp

@@ -443,16 +443,15 @@ void string_replace_all(std::string & s, const std::string & search, const std::
     s = std::move(builder);
 }
 
-bool string_ends_with(const std::string & str, const std::string & suffix) {
+bool string_ends_with(const std::string_view & str, const std::string_view & suffix) {
     return str.size() >= suffix.size() && str.compare(str.size()-suffix.size(), suffix.size(), suffix) == 0;
 }
-
-size_t string_find_partial_stop(const std::string & str, const std::string & stop) {
+size_t string_find_partial_stop(const std::string_view & str, const std::string_view & stop) {
     if (!str.empty() && !stop.empty()) {
         const char text_last_char = str.back();
         for (int64_t char_index = stop.size() - 1; char_index >= 0; char_index--) {
             if (stop[char_index] == text_last_char) {
-                const std::string current_partial = stop.substr(0, char_index + 1);
+                const auto current_partial = stop.substr(0, char_index + 1);
                 if (string_ends_with(str, current_partial)) {
                     return str.size() - char_index - 1;
                 }

common/common.h

@@ -6,6 +6,7 @@
 
 #include <set>
 #include <string>
+#include <string_view>
 #include <vector>
 #include <sstream>
 
@@ -500,8 +501,8 @@ static bool string_starts_with(const std::string & str,
 }
 
 // While we wait for C++20's std::string::ends_with...
-bool string_ends_with(const std::string & str, const std::string & suffix);
-size_t string_find_partial_stop(const std::string &str, const std::string &stop);
+bool string_ends_with(const std::string_view & str, const std::string_view & suffix);
+size_t string_find_partial_stop(const std::string_view & str, const std::string_view & stop);
 
 bool string_parse_kv_override(const char * data, std::vector<llama_model_kv_override> & overrides);
 void string_process_escapes(std::string & input);