File tree Expand file tree Collapse file tree 1 file changed +1
-4
lines changed Expand file tree Collapse file tree 1 file changed +1
-4
lines changed Original file line number Diff line number Diff line change @@ -2863,12 +2863,9 @@ static void ggml_metal_encode_node(
28632863
28642864 // for now the matrix-matrix multiplication kernel only works on A14+/M1+ SoCs
28652865 // AMD GPU and older A-chips will reuse matrix-vector multiplication kernel
2866- // !!!
2867- // TODO: for now, always use mat-vec kernels until we figure out how to improve the
2868- // indirect matrix multiplication
2869- // !!!
28702866 if ([device supportsFamily: MTLGPUFamilyApple7] &&
28712867 ne00 % 32 == 0 && ne00 >= 64 &&
2868+ ne01 / ne02 >= 512 && // NOTE: this is based on Mixtral shapes, might need adjustments
28722869 dst_rows > dst_rows_min) {
28732870 // some Metal matrix data types require aligned pointers
28742871 // ref: https://developer.apple.com/metal/Metal-Shading-Language-Specification.pdf (Table 2.5)
You can’t perform that action at this time.
0 commit comments