Skip to content

Commit a406d6a

Browse files
committed
Merge two assert_equals per CISC's request.
1 parent 9056707 commit a406d6a

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

tests/test-chat-parser.cpp

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,19 @@
1414
#include "log.h"
1515
#include "regex-partial.h"
1616

17+
template<class T>
18+
static void assert_equals(const char* label, const T& expected, const T& actual) {
19+
if (expected != actual){
20+
std::ostringstream oss;
21+
if (label && *label) oss << label << '\n';
22+
oss << "Expected: " << expected << "\nActual: " << actual;
23+
throw std::runtime_error(oss.str());
24+
}
25+
}
26+
1727
template <class T>
1828
static void assert_equals(const T & expected, const T & actual) {
19-
if (expected != actual) {
20-
std::cerr << "Expected: " << expected << std::endl;
21-
std::cerr << "Actual: " << actual << std::endl;
22-
std::cerr << std::flush;
23-
throw std::runtime_error("Test failed");
24-
}
29+
assert_equals("", expected, actual);
2530
}
2631
static void assert_equals(const char * expected, const std::string & actual) {
2732
return assert_equals<std::string>(expected, actual);
@@ -201,14 +206,6 @@ static void test(const std::string & input, bool is_partial, const std::vector<s
201206
assert_equals(expected, args_paths.size() == 1 && args_paths[0].empty() ? js->value.get<std::string>() : js->value.dump());
202207
}
203208

204-
template<typename T>
205-
static void assert_equals(const char* label, const T& expected, const T& actual) {
206-
if (!(expected == actual)) {
207-
std::ostringstream oss; oss << label << "\nExpected: " << expected << "\nActual: " << actual;
208-
throw std::runtime_error(oss.str());
209-
}
210-
}
211-
212209
static void test_deepseek_v3_1_tool_calls() {
213210
//common_log_set_verbosity_thold(LOG_DEFAULT_DEBUG);
214211
// variant: happy path for when it works as the model card says it should

0 commit comments

Comments
 (0)